Add Vertical lines to the sidebar#2633
Merged
bgravenorst merged 6 commits intomainfrom Jan 27, 2026
Merged
Conversation
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bgravenorst
changed the title
Member
|
Love it!! |
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| )} | ||
| // Avoid CSS :has() dependency by stamping state on the row element | ||
| data-current-page={isActive ? 'true' : undefined} | ||
| key={label} |
There was a problem hiding this comment.
Unnecessary key prop on component root element
Low Severity
The key={label} prop on the root <li> element doesn't serve its intended purpose. React's list reconciliation uses keys at the component boundary level (when the parent maps over items), not on elements returned inside components. The parent component (Docusaurus's DocSidebarItems) handles keying when rendering DocSidebarItemLink components. This key prop is effectively dead code that could confuse developers into thinking it helps with list reconciliation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue(s) fixed
Fixes #2632 and #2624
Preview
Checklist
Note
Introduces a refined docs sidebar with vertical guide lines, consistent indentation, and clearer active/hover states, plus a selected-row background highlight that doesn’t tint entire subtrees.
theme/_sidebar.scssfor tree lines, indentation, hover/active behavior, and dark mode tweaks; highlights current row using--doc-sidebar-line-xanddata-current-pageDocSidebarItem/Categoryto stampdata-current-page; adds newDocSidebarItem/Linkcomponent with external-link handling anddata-current-pagesupport@media (min-width: 1900px)root font-size bump inapp.scssto avoid large-screen typography jumpWritten by Cursor Bugbot for commit 98702dd. This will update automatically on new commits. Configure here.