Version v11.7.0 #22101
Merged
Version v11.7.0 #22101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… symbol (#21500) ## **Description** This PR addresses the issue of users being scammed by being coached to add custom testnet or worthless tokens with well-known cryptocurrency symbols. The PR updates a warning message copy for a mismatch between the Chain ID and the Currency Symbol ## **Manual testing steps** 1. Run `yarn start` and open extension 2. Go to Settings > Network > Add New Network 3. Add Chain Id 137 (polygon) and Currency Symbol ETH 4. Verify that the mismatch error shows and the text is as following: _“This network doesn’t match its associated chain ID or name. Many popular tokens use the name [NAME], making it a target for scams. Scammers may trick you into sending them more valuable currency in return. Verify everything before you continue.”_ ## **Screenshots/Recordings** _If applicable, add screenshots and/or recordings to visualize the before and after of your change._ ### **Before** <img width="419" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/fe696997-f4a1-4c8b-a7b8-4e3fe732915f"> ### **After** <img width="422" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/fdd3742a-97d3-47c8-af20-4facd74764ba"> ## **Related issues** Fixes https://github.com/MetaMask/MetaMask-planning/issues/1495 ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained: - [X] What problem this PR is solving. - [X] How this problem was solved. - [X] How reviewers can test my changes. - [X] I’ve indicated what issue this PR is linked to: Fixes #??? - [X] I’ve included tests if applicable. - [X] I’ve documented any added code. - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [X] I’ve properly set the pull request status: - [X] In case it's not yet "ready for review", I've set it to "draft". - [X] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
I think we should revert #21815 because it was squashed and merged, which doesn't leave us with the desired git history, and can make the diffs (commit lists) on future release PRs more confusing. So we will revert and then re-do the master sync PR, using the merge commit option
Re-do of the master sync because we reverted the earlier one #21825 --------- Co-authored-by: seaona <54408225+seaona@users.noreply.github.com> Co-authored-by: Howard Braham <howrad@gmail.com> Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net> Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com> Co-authored-by: Owen Craston <owengc12@gmail.com> Co-authored-by: António Regadas <apregadas@gmail.com> Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: micaelae <100321200+micaelae@users.noreply.github.com> Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com> Co-authored-by: salimtb <salim.toubal@outlook.com>
Reverting because the master sync PR was squashed and merged (for the second time today 😄 ), which doesn't leave us with the desired git history, and can make the diffs (commit lists) on future release PRs more confusing. So we will revert and then re-do the master sync PR, using the merge commit option
## **Description** This PR aims to replace the `txController` constructor argument in the `MMIController` with correspondent callbacks to decouple the `MMIController` from the `TransactionController` and support the transition of the core `TransactionController` in future. ## **Related issues** Fixes:MetaMask/MetaMask-planning#1656 ## **Manual testing steps** Regression test for transactions (cancel/speedup not supported by MMI build) **MMI** - Go to MMI test dapp: https://consensys.gitlab.io/codefi/products/mmi/test-dapp/ - Connect - Send transaction - Check if it is successfully confirmed ## **Screenshots/Recordings** [MMI-test.webm](https://github.com/MetaMask/metamask-extension/assets/45455812/02110e1e-f0d1-478c-b9b1-bb131603acf5)
## **Description** Enables the snaps home page feature in Flask and adds the UI logic to support it. When viewing a snap with a home page, this page will be shown before the current settings page. If the snap has no home page the experience is identical to the previous experience. ## **Related issues** Fixes: MetaMask/MetaMask-planning#1384 ## **Manual testing steps** 1. Install the home page example snap from https://metamask.github.io/snaps/test-snaps/latest/ 2. Go to the snap home page from the 3-dot menu ## **Screenshots/Recordings** 
Master sync follow v11.5.0
…arning (#21695) ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Adds e2e test for Blockaid Security Alert for set approval for farming warning. ## **Related issues** Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1454 ## **Manual testing steps** yarn build:test && yarn test:e2e:single test/e2e/tests/ppom-blockaid-setApprovalForAll-farming.spec.js --browser=chrome ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ### **After** https://github.com/MetaMask/metamask-extension/assets/29962968/2165f07c-97a6-4ae6-bc70-c9a208e9d7ab ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…1729) ## **Description** We decided to implement a tabbed interface for the new send flow with regard to the address book and accounts. ## **Related issues** Fixes: MetaMask/MetaMask-planning#1636 ## **Manual testing steps** 1. Open the new send flow 2. See contacts listed under the Contacts tab 3. See accounts under the accounts tab ## **Screenshots/Recordings** ### **Before** N/A ### **After** <img width="399" alt="SCR-20231107-mtsk" src="https://github.com/MetaMask/metamask-extension/assets/46655/73137494-cd5b-4e4a-90f6-e975b85c8570"> <img width="380" alt="SCR-20231107-mrue" src="https://github.com/MetaMask/metamask-extension/assets/46655/2164912a-b6f2-4dc4-9d6a-2aca76a74ed9"> <img width="408" alt="SCR-20231107-mrsw" src="https://github.com/MetaMask/metamask-extension/assets/46655/532b5215-cff0-4713-a537-9ea7f7daa56d"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Enables two permissions in stable: - `endowment:lifecycle-hooks` - `snap_getLocale` These are already fully implemented in Flask, this just enables them to be used in stable as well. With this PR we also enable their E2E tests in stable.
## **Description** We add a “Continue to wallet“ button under the current one, for the users to click if they don’t want to continue the MMI onboarding into the PD Dashboard and want to jump straight to the wallet. We also prevent the user from going back on the onboarding, even if neither of the buttons were clicked, therefore making the decision of either continue the onboarding or going to the wallet mandatory. ## **Related issues** Fixes: # ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="667" alt="Screenshot 2023-11-13 at 15 14 32" src="https://github.com/MetaMask/metamask-extension/assets/1125631/369776a6-7c12-43fb-8c79-79cacfdcbbbd"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Add app installed metric e2e test ## **Related issues** Closes: #21717 ## **Manual testing steps** Make sure the test pass. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained what problem this PR is solving and how it is solved. - [X] I've linked related issues - [X] I've included manual testing steps - [X] I've included screenshots/recordings if applicable - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** In MMI we want to show the custodian logo next to the wallet address, previously it was not even visible without being in the expand view. So now if the account selected is from a custodian, it will render its logo, if not, renders nothing like it always did. ## **Related issues** Fixes: # ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="394" alt="Screenshot 2023-11-10 at 17 16 46" src="https://github.com/MetaMask/metamask-extension/assets/1125631/f549b7d3-d674-40fb-a950-ecc6962faab9"> ### **After** In MMI: <img width="398" alt="Screenshot 2023-11-10 at 17 16 39" src="https://github.com/MetaMask/metamask-extension/assets/1125631/c7bc1e62-ab3d-4699-978d-ba53c746b5d3"> In MM (unchanged) <img width="409" alt="Screenshot 2023-11-13 at 15 21 32" src="https://github.com/MetaMask/metamask-extension/assets/1125631/360d89a9-466c-4f78-85b7-5a6aa078ea6f"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Bumps `@metamask/assets-controllers` to `v18.0.0` which includes breaking changes for the CurrencyRateController. Notably the structure of the state has changed significantly. Part of making the state change so drastic (as opposed to making the refactor towards Multichain be as small/incremental as possible), is that the usage of `pendingNativeCurrency`, `pendingCurrentCurrency`, and how the controller handles state change in general causes unexpected behavior with concurrent updates. The update to CurrencyRateController also solves this issue. ## **Related issues** Fixes: MetaMask/MetaMask-planning#1025 Related: MetaMask/core#1687 ## **Manual testing steps** Nothing should change for the end user. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Alex Donesky <adonesky@gmail.com>
## **Description** Bump snaps packages to latest. Summary of changes in the snaps deps: - Use `SubtleCrypto` for checksum calculation if available - This reduces the time of the checksum calculation by up to 95% in some environments. - Use `metamask/snaps-sdk` package - Fixed a checksum calculation bug with localized manifests
The end-to-end test that was originally flaky doesn't send sentry events for all migrations, only a subset of them. I am still not 100% sure about the original source of the flakiness. One possible explanation is that migrations take a variable amount of time to run. This PR skips the flaky test until we understand more about the root cause.
- Some flaky tests were outputting invisible error messages coming from the Chrome console. This PR makes them visible. - If Ganache hit an error while closing, it could cause cascading errors in CI.
## **Description** This PR cherry-picks #20380, which contains copy changes for the "Enable Opensea API" => "Display NFT Media" toggle. Previously, this PR was reverted on #21109 due to some needed changes in the NFT controllers. [Those changes have now been made](MetaMask/core#1772). Changes: * updated copy changes * updated snapshots * lint fix * updated test ## **Related issues** Fixes MetaMask/MetaMask-planning#1015 ## **Manual testing steps** 1. Go to the "Security & privacy" settings page 2. See the new copy ## **Screenshots/Recordings** ### **Before** <img width="640" alt="Screenshot 2023-11-07 at 11 49 19" src="https://github.com/MetaMask/metamask-extension/assets/13814744/723bbd7c-0869-4cae-9b3c-a443db93b66d"> ### **After** <img width="640" alt="Screenshot 2023-11-07 at 11 46 03" src="https://github.com/MetaMask/metamask-extension/assets/13814744/43565588-f26e-431c-bed2-700598170ef3"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
# **Description** The CTA on the snaps grid to redirect to the snaps details page said: "Install." This change is to more accurately describe the button's behavior by changing the copy to "Details." ## **Manual testing steps** 1. ```bash yarn jest snap-card.test.tsx``` ## **Screenshots/Recordings** ### **After** Please see this screenshot from the storybook. To reproduce, you can build the storybook and navigate to Compents/UI/SnapCard. <img width="323" alt="Screenshot 2023-10-16 at 4 06 16 PM" src="https://github.com/MetaMask/metamask-extension/assets/91970214/3a570da5-b2ae-405d-8223-4be56aa7f608"> ## **Related issues** This fix addresses the [issue: #75](https://github.com/MetaMask/accounts-planning/issues/75) ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This change updates the backup copy in the "Advanced Settings" to reflect the proper action and update all the mentions of "backup" (noun) to "back up" (verb).
## **Description** This PR adds playwright test capabilities for the mmi extension build. It also adds functional and visual tests for that build. This is part of the MMI e2e legacy tests. NOTE: The new test set will be added to the current pipeline as a non-blocking step. This means that even if these tests fail, other Pull Requests can still be merged. However, a failure will trigger a warning indicating potential issues with MMI functionality due to the changes in these PRs. For more detailed info about how the MMI e2e tests works, check the README file within the `test/e2e/mmi` folder. ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ### **Before** N/A ### **After** N/A ## **Related issues** N/A ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained: - [ ] What problem this PR is solving. - [ ] How this problem was solved. - [ ] How reviewers can test my changes. - [ ] I’ve indicated what issue this PR is linked to: Fixes #??? - [ ] I’ve included tests if applicable. - [ ] I’ve documented any added code. - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
…esent (#21637) ## **Description** Prior to this change, the transaction spinner would load infinitely when an snap account send a transaction in async mode. This is a problem for multi party compute snaps since we prompt the user to complete the signing of the transaction on the snap website. This new change detects if the approval modal is open and then hides the spinner. This is an example response for the pending confirmations ```js [ { "id": "b7749d90-8341-11ee-82f4-c904b44c9d3f", "origin": "metamask", "type": "showSnapAccountRedirect", "time": 1700002876919, "requestData": { "txId": "b7749d90-8341-11ee-82f4-c904b44c9d3f" }, "requestState": null, "expectsResult": true } ] ``` I was able to show/hide the spinner by checking if any of the sub objects within the pendingConfirmations array contained the type `showSnapAccountRedirect` ## **Related issues** Fixes: # ## **Manual testing steps** 1. You will need an account with funds to test this change. Test net funds suffice. 2. Navigate to the snap simple keyring site: https://metamask.github.io/snap-simple-keyring/1.0.1/ 3. Create an account, the extension should prompt you to allow this account addition. accept this approval flow. 4. open the extension, and click the account list at the top. you should see a new account in your list with the tag `Snaps (Beta)` 5. Fund this new account by sending a small amount of funds to your new snap account 6. Navigate back to the Snap Simple Keyring site: https://metamask.github.io/snap-simple-keyring/1.0.1/ 7. Turn off `Use Synchronous Approval` so that the toggle is grey <img width="319" alt="Screenshot 2023-10-31 at 3 15 46 PM" src="https://github.com/MetaMask/metamask-extension/assets/22918444/6061a916-5791-471e-bbf9-597bdffcf021"> 9. Navigate back to the extension, select your new snap account and send a transaction (assuming you have funded this new account) 10. Confirm the transaction 11. `The spinner should only load for a second` 12. there should be an approval pop up triggered that prompts you to redirect to the `Snap Simple Keyring` site 13. you can approve the transaction by clicking `list request` on the Snap Simple Keyring site, copying the `request id` and pasting it into the `Approve request` box. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-extension/assets/22918444/da6489f6-0613-4f5f-8da8-f654eaf6e35d ### **After** https://github.com/MetaMask/metamask-extension/assets/22918444/813a3c2f-7a03-495e-ba52-c5a118216ec0 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Howard Braham <howrad@gmail.com>
## **Description** Implements a new `AddressListItem` component which looks similar to the `AccountListItem` but is much lighter and does not attempt to show totals or anything other than a `label` and `address` ## **Related issues** Fixes: MetaMask/MetaMask-planning#1566 ## **Manual testing steps** 1. `MULTICHAIN=1 yarn start` 2. Enter send flow 3. Look at the Contact List -- see this new component for each item 4. Click an item, see it populated to "To" field 5. Empty "To" field 6. In the "To" field, type "metamask.eth" 7. See search items look the same. ## **Screenshots/Recordings** ### **Before** <img width="410" alt="SCR-20231027-lzap" src="https://github.com/MetaMask/metamask-extension/assets/46655/6515123c-c8a8-4ecb-94cc-89d98ec639b2"> ### **After** <img width="435" alt="SCR-20231027-lxjo" src="https://github.com/MetaMask/metamask-extension/assets/46655/31029b92-9c86-4266-b7c0-0da410ac2dbf"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Fixes alignment of the Send button in the NFT popup. ## **Related issues** Fixes: #21716 ## **Manual testing steps** 1. Open the MetaMask popup 2. Click on any NFT 3. See the send button properly aligned ## **Screenshots/Recordings** ### **Before**  ### **After** <img width="364" alt="SCR-20231113-nebq" src="https://github.com/MetaMask/metamask-extension/assets/46655/498192b5-c20b-474b-88ed-782f113472c6"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Changes: - deprecates the use of U2F and Ledger Live on chrome - adds whats new notification - new migration to set the ledgerTransportType to webhid for all chrome users. --------- Co-authored-by: Howard Braham <howrad@gmail.com>
## **Description** Bump snaps packages to latest. Summary of changes in the snaps deps: - Pause request timer when `fetch` is called - More behind the scenes work to support snap UI links
## **Description** Fixes #21598 Fixes #21837 Fixes #21834 ### Explanation of the bug There is a bug in production that prevents users from opening MetaMask if when they last stopped MetaMask (usually by closing the browser), the network they had selected is no longer working. In these cases, when they attempt to open MetaMask, there is an infinite spinner. What is happening is that [await this.accountTracker._updateAccounts();](https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/metamask-controller.js#L3408) in `_loginUser` is never resolving, so `this._startUISync();` is never called ``` async _loginUser() { try { // Automatic login via config password const password = process.env.PASSWORD; if (password && !process.env.IN_TEST) { await this.submitPassword(password); } // Updating accounts in this.accountTracker before starting UI syncing ensure that // state has account balance before it is synced with UI await this.accountTracker._updateAccounts(); } finally { this._startUISync(); } } ``` which means that [this](https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/ui.js#L200C18-L200C18) `initializeUiWithTab(activeTab);` call in `ui.js` never occurs, and so the UI is never initialized. The `await this.accountTracker._updateAccounts();` is not resolving because ` const balances = await ethContract.balances(addresses, ethBalance);` in `_updateAccountsViaBalanceChecker` in `account-tracker.js` never resolves. This is happening because calling `ethContract.balances` results in a `eth_call` request being passed through our middleware, and it has to go through the `createBlockRefRewriteMiddleware`, [which has the following](https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/src/block-ref-rewrite.ts#L41): `const latestBlockNumber = await blockTracker.getLatestBlock();` The `blockTracker.getLatestBlock` function has this line of code: ``` const latestBlock: string = await new Promise((resolve) => this.once('latest', resolve), ); ``` So ultimately our code is waiting on a `'latest'` event to be emitted from within a block tracker. But because the user is on a network that is broken, no successful block polling is occuring, and therefore a `'latest'` block/event is never emitted, and therefore `getLatestBlock` is awaiting forever, and so-on up the call stack. ### When was the bug introduced The behaviour of the blocktracker is long standing. However, users have begun to experience this bug recently because of this commit 48184fe That commit introduced the listener for `startUISync` in `ui.js`, which is what is not occuring when we get stuck on the above mentioned `getLatestBlock` call. That commit was introduced to prod with v11.3.0 ### Explanation of the fix To quickly fix this bug so that we can release a hotfix, this PR eliminates the `_loginUser` call in the MetaMask Controller when we are not in a local dev build. It makes that call dependent on the presence of `process.env.PASSWORD`, which only occurs on development builds. This is acceptable because `_loginUser` is only used for the purpose of allowing devs to skip the password screen when doing local development. It does not serve any useful purpose in production. A deeper fix would possibly be to introduce a timeout at some point in the call stack, or to have `getLatestBlock` also listen for some sort of error event, and throw up an error if it occurs. ## **Manual testing steps** Here is how I reproduce this bug on `develop`: 1. Build metamask locally from the develop branch 2. Copy the contents of `dist/chrome` to a new folder, and install metamask from this folder. Onboard. 3. Go to chainlist.org, toggle open the Ethereum Mainnet options, and add one of these eth mainnet custom networks, and switch to that network 4. Open the background console 5. Enter `chrome.storage.local.get(console.log)` into the console. An object will be logged. Inspect the object and in particular the NetworkController. Find the unique id of the network you just added. It will look something like `0b29f8c9-bc0e-4058-a4a1-c39c5a5bb90e` 6. For the below script, replace each instance of `0b29f8c9-bc0e-4058-a4a1-c39c5a5bb90e` with the unique network id you copied in step 3. Copy and paste this revised script to the background console and run it 7. Reload the metamask-extension 8. Attempt to open the extension and you should see an infinite spinner, with a white background and no log in screen. Reloading the extension and closing an re-opening the browser doesn't fix the problem. Then, switch to the branch of this PR, build locally, and copy the new contents of `dist/chrome` to the folder you created in step 2 and reload the extension. Now you should still see a loading spinner, but you should be able to switch networks and then login The script to modify and run in step 6 is: ``` chrome.storage.local.get(({ data, meta }) => { let currentData = structuredClone(data) let newNetworkConfigurations = { ...currentData.NetworkController.networkConfigurations } newNetworkConfigurations["0b29f8c9-bc0e-4058-a4a1-c39c5a5bb90e"] = { "chainId": "0x1", "id": "0b29f8c9-bc0e-4058-a4a1-c39c5a5bb90e", "nickname": "Pokt", "rpcPrefs": {}, "rpcUrl": "https://eth-rpc.gateway.pokt.network", "ticker": "ETH" } let newProviderConfig = { ...currentData.NetworkController.providerConfig } newProviderConfig["0b29f8c9-bc0e-4058-a4a1-c39c5a5bb90e"] = { "chainId": "0x1", "id": "0b29f8c9-bc0e-4058-a4a1-c39c5a5bb90e", "nickname": "Pokt", "rpcPrefs": {}, "rpcUrl": "https://eth-rpc.gateway.pokt.network", "ticker": "ETH", "type": "rpc" } let newData = { ...currentData, NetworkController: { ...currentData.NetworkController, networkConfigurations: newNetworkConfigurations, providerConfig: newProviderConfig, } } return chrome.storage.local.set({ data: newData, meta, }, () => { window.location.reload() }) }) ``` ## **Screenshots/Recordings** ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Fixes a typo in the selectedAddress variable. [Original PR](#22138) 9bd1025 There were no merge conflicts when picking this commit. ## **Related issues** Fixes: # ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: chloeYue <105063779+chloeYue@users.noreply.github.com>
Builds ready [71cec71]
Page Load Metrics (676 ± 270 ms)
|
|
🟢 Confirmations UX Team QA Sign Off |
…d symbol (#21919) (#22170) ## **Description** This adds a warning label in the currency symbol position when a native token has an incorrect symbol ## **Related issues** Fixes: https://app.zenhub.com/workspaces/metamask-extension-63529dce65cbb100265a3842/issues/gh/metamask/metamask-planning/1652 ## **Manual testing steps** 1. Add a network with chain `137` (Polygon, but call it "Polyfraud") with incorrect symbol (`ETH`) 2. Switch to Polyfraud network 3. See red "danger" icon 4. Hover over said icon 5. See the modal with important information about potential fraud ## **Screenshots/Recordings** ### **Before** N/A ### **After** <img width="716" alt="SCR-20231121-nbrz" src="https://github.com/MetaMask/metamask-extension/assets/46655/be1bccc3-5788-4233-a2fb-09fbf77713a3"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Cherry-pick features to stop pulling after UI is closed #22123 and add headers to request going to CoinGecko #22151 See more info here: https://consensys.slack.com/archives/C065W3877E3/p1701450197502839 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** Refer to #22123 and #22151 ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
🟢 Snaps Team QA Signs Off ✅ |
Builds ready [72991dd]
Page Load Metrics (532 ± 258 ms)
|
## **Description** Changelog for RC 11.7.0 ## **Related issues** ## **Manual testing steps** Not necessary ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained what problem this PR is solving and how it is solved. - [X] I've linked related issues - [X] I've included manual testing steps - [X] I've included screenshots/recordings if applicable - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [X] I’ve properly set the pull request status: - [X] In case it's not yet "ready for review", I've set it to "draft". - [X] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Builds ready [d624ed0]
Page Load Metrics (783 ± 333 ms)
|
gauthierpetetin
added
the
release-11.7.0
gauthierpetetin
added
release-11.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.