test(perf): harden cloud Appium waits and performance selectors (#34008)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

Backports BrowserStack-safe performance E2E hardening from
`MMQA-2042-TestMU-PoC` into `main`, without bringing any TestMu AI
provider, CI wiring, secrets, or PoC device-matrix changes.

Cloud Appium visibility polls were paying an implicit-wait round-trip on
every probe, which inflated measured durations. Perps and warm-start
readiness also waited on fragile selectors. This PR:

1. Sets Appium implicit wait once per visibility poll (not per probe) in
`PlaywrightAssertions`
2. Waits on the Perps withdraw control for market-list readiness and
dismisses the tutorial before measuring
3. Asserts warm-start wallet readiness via the hamburger menu instead of
the wallet container
4. Scrolls QuoteView “more networks” into view before tapping a network
5. Tightens Playwright performance grep to bare `@Performance`
(`/@performance\b/`)

Explicitly out of scope: TestMu provider/enricher/tunnel scripts, TestMu
performance workflow jobs, `LT_*` / `TESTMU_*` secrets wiring, and Pixel
7 Pro PoC matrix mapping.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: MMQA-2042

## **Manual testing steps**

```gherkin
Feature: performance E2E cloud wait hardening

  Scenario: warm start unlock reaches wallet
    Given a BrowserStack Android performance imported-wallet session
    When the warm-start login-to-wallet scenario unlocks the app
    Then the hamburger menu becomes visible within the step threshold
    And the measured duration is not inflated by per-probe implicit waits

  Scenario: Perps market list readiness
    Given a BrowserStack Android performance onboarding session with Perps
    When the Perps tutorial is dismissed if present
    Then the withdraw control is used as the market-list readiness signal
    And the select-market timer starts only after that control is visible

  Scenario: QuoteView network selection
    Given QuoteView is open and additional networks are below the fold
    When the test selects a network via Appium
    Then “more networks” is scrolled fully into view before the network tap
```

N/A for interactive app QA beyond BrowserStack performance suites above
— this PR only changes test/CI helper code.

## **Screenshots/Recordings**

N/A — test-infrastructure and CI setup changes only; no end-user UI
changes.

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

## **Test plan**

- [ ] CI status checks pass on this PR
- [ ] Diff contains only the 7 intended files (no TestMu / `LT_*` /
`TESTMU_*` wiring)
- [ ] Spot-check BrowserStack Android performance onboarding +
imported-wallet (warm-start, Perps, network selection)
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-18cd73a7-d8af-42b0-ba8b-9ed0c1c62b2a"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-18cd73a7-d8af-42b0-ba8b-9ed0c1c62b2a"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>

Author: javiergarciavera

tests/framework/Constants.ts

@@ -105,6 +105,24 @@ export const DEFAULT_ACTION_TIMEOUT_MS = 5_000;
 /** WebDriver HTTP timeout for BrowserStack session creation (grid can take several minutes). */
 export const DEFAULT_BROWSERSTACK_CONNECTION_RETRY_TIMEOUT_MS = 300_000;
 
+/**
+ * WDIO HTTP request retries for BrowserStack hub calls (including POST /session).
+ * Busy grids often abort session creation once; a higher count recovers without
+ * burning a full Playwright test retry.
+ */
+export const DEFAULT_BROWSERSTACK_CONNECTION_RETRY_COUNT = 5;
+
+/**
+ * Outer attempts in BrowserStackProvider.getDriver() when session creation fails
+ * with a transient hub/timeout error after WDIO's own connection retries.
+ * This is the session-only retry path — Playwright test retries stay at the
+ * shared CI default and are not raised for product/threshold failures.
+ */
+export const DEFAULT_BROWSERSTACK_SESSION_CREATE_MAX_ATTEMPTS = 5;
+
+/** Backoff between BrowserStackProvider session-create attempts, in ms. */
+export const DEFAULT_BROWSERSTACK_SESSION_CREATE_RETRY_DELAY_MS = 5_000;
+
 /** BrowserStack maximum allowed idle timeout between WebDriver commands, in seconds. */
 export const DEFAULT_BROWSERSTACK_IDLE_TIMEOUT_SECONDS = 300;
 

tests/framework/PlaywrightAssertions.ts

@@ -44,6 +44,10 @@ export default class PlaywrightAssertions {
    * (`isExisting`). This avoids the multiple internal HTTP round-trips that
    * WebdriverIO's `waitForDisplayed` performs on each iteration.
    *
+   * Implicit wait is set once for the whole poll (not per attempt) so cloud
+   * Appium providers do not pay 2× `setTimeout` RTT every probe — that
+   * overhead was inflating performance timers.
+   *
    * When measuring, only the successful confirm (+ probe) counts as infra.
    * A shorter poll interval reduces detection lag without zeroing app time.
    */
@@ -62,31 +66,41 @@ export default class PlaywrightAssertions {
       ? this.POLL_INTERVAL_WHILE_MEASURING_MS
       : this.POLL_INTERVAL_MS;
     const start = Date.now();
-    while (Date.now() - start < timeout - this.FINAL_WAIT_RESERVE_MS) {
-      const remaining = timeout - (Date.now() - start);
-      if (remaining <= 0) {
-        break;
-      }
-      const t0 = Date.now();
-      try {
-        const exists = await withImplicitWait(this.POLL_IMPLICIT_WAIT_MS, () =>
-          el.unwrap().isExisting(),
-        );
-        if (exists) {
-          const displayed = await el.isVisible();
-          if (displayed) {
-            if (tracking) {
-              recordSuccessPollCommand(Date.now() - t0);
-              await this.probeOverhead(el);
+
+    const found = await withImplicitWait(
+      this.POLL_IMPLICIT_WAIT_MS,
+      async () => {
+        while (Date.now() - start < timeout - this.FINAL_WAIT_RESERVE_MS) {
+          const remaining = timeout - (Date.now() - start);
+          if (remaining <= 0) {
+            break;
+          }
+          const t0 = Date.now();
+          try {
+            const exists = await el.unwrap().isExisting();
+            if (exists) {
+              const displayed = await el.isVisible();
+              if (displayed) {
+                if (tracking) {
+                  recordSuccessPollCommand(Date.now() - t0);
+                  await this.probeOverhead(el);
+                }
+                return true;
+              }
             }
-            return;
+          } catch {
+            // element not ready yet
           }
+          await sleep(Math.min(interval, remaining));
         }
-      } catch {
-        // element not ready yet
-      }
-      await sleep(Math.min(interval, remaining));
+        return false;
+      },
+    );
+
+    if (found) {
+      return;
     }
+
     const remainingTimeout = timeout - (Date.now() - start);
     await el.waitForDisplayed({
       timeout: Math.max(interval, remainingTimeout),

tests/framework/services/providers/browserstack/BrowserStackConfigBuilder.ts

@@ -3,6 +3,7 @@ import path from 'path';
 import type { BrowserStackConfig } from '../../../types';
 import type { ProjectConfig } from '../../common/types';
 import {
+  DEFAULT_BROWSERSTACK_CONNECTION_RETRY_COUNT,
   DEFAULT_BROWSERSTACK_CONNECTION_RETRY_TIMEOUT_MS,
   DEFAULT_BROWSERSTACK_IDLE_TIMEOUT_SECONDS,
   DEFAULT_BROWSERSTACK_NEW_COMMAND_TIMEOUT_SECONDS,
@@ -79,7 +80,8 @@ export class BrowserStackConfigBuilder {
       : DEFAULT_BROWSERSTACK_CONNECTION_RETRY_TIMEOUT_MS;
 
     logger.info(
-      `BrowserStack WebDriver connectionRetryTimeout: ${connectionRetryTimeout}ms`,
+      `BrowserStack WebDriver connectionRetryTimeout: ${connectionRetryTimeout}ms, ` +
+        `connectionRetryCount: ${DEFAULT_BROWSERSTACK_CONNECTION_RETRY_COUNT}`,
     );
     logger.info(
       `BrowserStack idleTimeout: ${DEFAULT_BROWSERSTACK_IDLE_TIMEOUT_SECONDS}s, newCommandTimeout: ${DEFAULT_BROWSERSTACK_NEW_COMMAND_TIMEOUT_SECONDS}s`,
@@ -98,7 +100,7 @@ export class BrowserStackConfigBuilder {
       hostname: 'hub.browserstack.com',
       // Default webdriver is 120s; BS session POST often exceeds that on busy grids.
       connectionRetryTimeout,
-      connectionRetryCount: 3,
+      connectionRetryCount: DEFAULT_BROWSERSTACK_CONNECTION_RETRY_COUNT,
       capabilities: {
         'bstack:options': {
           debug: true,

tests/framework/services/providers/browserstack/BrowserStackProvider.ts

@@ -1,9 +1,57 @@
 import { remote, type Browser } from 'webdriverio';
 import { BaseServiceProvider } from '../../common/base/BaseServiceProvider.ts';
 import type { ProjectConfig } from '../../common/types.ts';
+import {
+  DEFAULT_BROWSERSTACK_SESSION_CREATE_MAX_ATTEMPTS,
+  DEFAULT_BROWSERSTACK_SESSION_CREATE_RETRY_DELAY_MS,
+} from '../../../Constants.ts';
 import { BrowserStackAPI } from './BrowserStackAPI.ts';
 import { BrowserStackConfigBuilder } from './BrowserStackConfigBuilder.ts';
 
+/**
+ * Only retry busy-grid / transport flakes. Do NOT match generic WDIO session
+ * text like "Failed to create a session" or "wd/hub/session" — those also
+ * appear for permanent failures (bad credentials, invalid app URL, caps).
+ */
+const TRANSIENT_SESSION_ERROR_PATTERNS = [
+  'aborted due to timeout',
+  'operation was aborted',
+  'ECONNRESET',
+  'ETIMEDOUT',
+  'ECONNREFUSED',
+  'socket hang up',
+  'network timeout',
+  'All parallel tests are currently in use',
+  'All devices are busy',
+  'DEVICE_QUEUE_TIMEOUT',
+] as const;
+
+const PERMANENT_SESSION_ERROR_PATTERNS = [
+  'Invalid username or password',
+  'Authentication failed',
+  'Unauthorized',
+  'App not found',
+  'Invalid app',
+  'app_url',
+  'BROWSERSTACK_USERNAME',
+  'BROWSERSTACK_ACCESS_KEY',
+  'buildPath is required',
+] as const;
+
+function isTransientBrowserStackSessionError(error: unknown): boolean {
+  const message = error instanceof Error ? error.message : String(error);
+  if (
+    PERMANENT_SESSION_ERROR_PATTERNS.some((pattern) =>
+      message.includes(pattern),
+    )
+  ) {
+    return false;
+  }
+  return TRANSIENT_SESSION_ERROR_PATTERNS.some((pattern) =>
+    message.includes(pattern),
+  );
+}
+
 /**
  * Service provider for BrowserStack cloud testing
  */
@@ -25,7 +73,9 @@ export class BrowserStackProvider extends BaseServiceProvider {
   }
 
   /**
-   * Create and return WebDriver browser instance for BrowserStack
+   * Create and return WebDriver browser instance for BrowserStack.
+   * Retries transient hub/session timeouts so a single busy-grid abort does
+   * not consume the whole Playwright test retry budget.
    */
   async getDriver(): Promise<Browser> {
     this.logger.info(
@@ -34,16 +84,52 @@ export class BrowserStackProvider extends BaseServiceProvider {
 
     const configBuilder = new BrowserStackConfigBuilder(this.project);
     const config = configBuilder.build();
-
+    const maxAttempts = DEFAULT_BROWSERSTACK_SESSION_CREATE_MAX_ATTEMPTS;
     const sessionCreationStart = Date.now();
-    const browser = await remote(config);
-    this.sessionCreationDurationMs = Date.now() - sessionCreationStart;
-    this.sessionId = browser.sessionId;
+    let lastError: unknown;
 
-    this.logger.info(
-      `Driver created for BrowserStack with session: ${this.sessionId} (session creation took ${this.sessionCreationDurationMs}ms)`,
-    );
-    return browser;
+    for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+      try {
+        const browser = await remote(config);
+        this.sessionCreationDurationMs = Date.now() - sessionCreationStart;
+        this.sessionId = browser.sessionId;
+
+        this.logger.info(
+          `Driver created for BrowserStack with session: ${this.sessionId} ` +
+            `(session creation took ${this.sessionCreationDurationMs}ms` +
+            (attempt > 1 ? `, attempt ${attempt}/${maxAttempts}` : '') +
+            `)`,
+        );
+        return browser;
+      } catch (error) {
+        lastError = error;
+        const message = error instanceof Error ? error.message : String(error);
+        const isTransient = isTransientBrowserStackSessionError(error);
+
+        if (!isTransient || attempt === maxAttempts) {
+          this.logger.error(
+            `BrowserStack session creation failed ` +
+              `(attempt ${attempt}/${maxAttempts}` +
+              `${isTransient ? ', transient' : ''}): ${message}`,
+          );
+          throw error;
+        }
+
+        this.logger.warn(
+          `BrowserStack session creation failed transiently ` +
+            `(attempt ${attempt}/${maxAttempts}); retrying in ` +
+            `${DEFAULT_BROWSERSTACK_SESSION_CREATE_RETRY_DELAY_MS}ms: ${message}`,
+        );
+        await new Promise((resolve) =>
+          setTimeout(
+            resolve,
+            DEFAULT_BROWSERSTACK_SESSION_CREATE_RETRY_DELAY_MS,
+          ),
+        );
+      }
+    }
+
+    throw lastError instanceof Error ? lastError : new Error(String(lastError));
   }
 
   /**

tests/page-objects/Onboarding/CreatePasswordView.ts

@@ -314,17 +314,20 @@ class CreatePasswordView {
   private async readMarketingCheckboxCheckedAppium(
     checkbox: Awaited<ReturnType<typeof asPlaywrightElement>>,
   ): Promise<boolean | undefined> {
-    try {
-      const attributes: Record<string, unknown> = {
-        'aria-checked': await checkbox.getAttribute('aria-checked'),
-        checked: await checkbox.getAttribute('checked'),
-        value: await checkbox.getAttribute('value'),
-      };
-
-      return this.parseMarketingCheckboxCheckedState(attributes);
-    } catch {
-      return undefined;
+    // Fetch attributes independently. Android UiAutomator2 does not support
+    // `aria-checked`; requesting it first used to abort the whole read and
+    // leave isChecked undefined (see seedless Apple/Telegram perf failures).
+    const attributes: Record<string, unknown> = {};
+
+    for (const name of ['checked', 'value', 'aria-checked'] as const) {
+      try {
+        attributes[name] = await checkbox.getAttribute(name);
+      } catch {
+        // Unsupported on this platform/driver — try the next candidate.
+      }
     }
+
+    return this.parseMarketingCheckboxCheckedState(attributes);
   }
 
   /**

tests/page-objects/Perps/PerpsMarketListView.ts

@@ -1,5 +1,6 @@
 import {
   PerpsHomeViewSelectorsIDs,
+  PerpsMarketBalanceActionsSelectorsIDs,
   PerpsMarketListViewSelectorsIDs,
   PerpsMarketRowItemSelectorsIDs,
   PerpsTokenSelectorSelectorsIDs,
@@ -141,6 +142,12 @@ class PerpsMarketListView {
     return Matchers.getElementByID(PerpsTokenSelectorSelectorsIDs.CLOSE_BUTTON);
   }
 
+  get withdrawButton() {
+    return Matchers.getElementByID(
+      PerpsMarketBalanceActionsSelectorsIDs.WITHDRAW_BUTTON,
+    );
+  }
+
   // Actions
   async tapMarketRowItemBTC() {
     await encapsulatedAction({

tests/page-objects/swaps/QuoteView.ts

@@ -465,6 +465,18 @@ class QuoteView {
         });
       },
       appium: async () => {
+        // Best-effort only: some swap flows never expose "more networks", and
+        // forcing scrollIntoView there fails Appium smoke after 30 scrolls.
+        try {
+          const moreNetworks = await asPlaywrightElement(
+            this.moreNetworksButton,
+          );
+          if (await moreNetworks.unwrap().isExisting()) {
+            await PlaywrightGestures.scrollIntoViewFullyVisible(moreNetworks);
+          }
+        } catch {
+          // Continue — the target network may already be visible without this control.
+        }
         const networkElement =
           await PlaywrightMatchers.getElementByCatchAll(network);
         await PlaywrightAssertions.expectElementToBeVisible(networkElement, {

tests/page-objects/wallet/AccountListBottomSheet.ts

@@ -54,8 +54,11 @@ class AccountListBottomSheet {
         ),
       appium: () =>
         PlatformDetector.isIOS()
-          ? PlaywrightMatchers.getElementByText(
+          ? // Exact match: contains("Accounts") also hits "Connect accounts" /
+            // "Edit accounts" nodes that can exist while displayed=false.
+            PlaywrightMatchers.getElementByText(
               AccountListBottomSheetSelectorsText.ACCOUNTS_LIST_TITLE,
+              true,
             )
           : PlaywrightMatchers.getElementById(
               AccountListBottomSheetSelectorsIDs.ACCOUNT_LIST_ID,
@@ -318,6 +321,7 @@ class AccountListBottomSheet {
           el = PlatformDetector.isIOS()
             ? await PlaywrightMatchers.getElementByText(
                 AccountListBottomSheetSelectorsText.ACCOUNTS_LIST_TITLE,
+                true,
               )
             : await PlaywrightMatchers.getElementById(
                 AccountListBottomSheetSelectorsIDs.ACCOUNT_LIST_ID,

tests/performance/device-matrix.json

@@ -1,16 +1,10 @@
 {
   "android_devices": [
-    {
-      "name": "Samsung Galaxy S25 Ultra",
-      "os_version": "15.0",
-      "category": "high",
-      "description": "High-end Samsung flagship device with Android 15"
-    },
     {
       "name": "Google Pixel 8 Pro",
       "os_version": "14.0",
       "category": "low",
-      "description": "High-end Google flagship device with Android 14"
+      "description": "Google Pixel 8 Pro with Android 14 — sole Android device for performance E2E (Galaxy removed to reduce cost/flakes)"
     }
   ],
   "ios_devices": [
@@ -33,11 +27,11 @@
     "low": "Low-end devices for backward compatibility and emerging market testing"
   },
   "os_coverage": {
-    "android": ["13.0", "14.0"],
+    "android": ["14.0"],
     "ios": ["16", "17"]
   },
   "notes": {
     "ios_limitations": "iPhone 11 (iOS 13) and iPhone 8 (iOS 11) have OS versions not supported by MetaMask app",
-    "android_performance": "TECNO KI5k included despite low-end specs due to high production volume (250.2K units) in emerging markets"
+    "android_performance": "Android performance E2E runs on Google Pixel 8 Pro only (Samsung Galaxy removed from the matrix)."
   }
 }

tests/performance/login/launch-times/warm-start-login-to-wallet.spec.ts

@@ -66,7 +66,7 @@ perfTest.describe(
         await LoginView.tapLoginButton();
         await timer1.measure(async () => {
           await PlaywrightAssertions.expectElementToBeVisible(
-            asPlaywrightElement(WalletView.container),
+            asPlaywrightElement(WalletView.hamburgerMenuButton),
             {
               description: 'Wallet balance should be visible',
               timeout: 30 * 1000, // 30 seconds