feat: Support returning a txHash asap, show a notification for a cancelled smart transaction

[dan437]

Description

This PR does a few things to support returning a txHash asap after a smart transaction is submitted:

• Shows a notification for a cancelled smart transaction
• Requires to send these params when calling the Smart Transactions controller: clientId, getFeatureFlags and updateTransaction

Related issues

Resolves this JIRA ticket: https://consensyssoftware.atlassian.net/browse/TXL-517

Manual testing steps

1. A feature flag for returning a txHash asap has to be set to true.
2. It can be tested e.g. via a dapp transaction. A dapp should receive a txHash asap right after submitting a smart transaction
3. We show a Toast notification for cancelled smart transaction (e.g. when very low gas fees are used) if a user closed the Smart Transaction status page

Screenshots/Recordings

Success Toast:

Pending smart transaction:

Cancelled smart transaction notification:

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/smart-transactions-controller@15.0.0	network	+3	2.09 MB	metamaskbot
npm/@metamask/transaction-controller@39.1.0	network	0	2.22 MB	metamaskbot

🚮 Removed packages: npm/@metamask/smart-transactions-controller@14.0.0, npm/@metamask/transaction-controller@37.3.0

View full report↗︎

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c81cecb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/753ae262-33ab-485e-a4a8-0758d6fc0604

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 563de6a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/67209eb6-ead0-4178-b841-ab871aca0916

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3a9a426
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06b8b852-1fb1-4455-99b7-22171bdd1d90

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: b1db459
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4d682c0a-e6ce-4bd5-b1cd-bcf277f302d4

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 98fb922
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4edc2984-d873-4915-a894-1ac459d9c926

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 20852cd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/96e696ab-dcb5-4481-98c4-bc6b02212d89

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (22a4989) to head (20852cd).
Report is 66 commits behind head on main.

Files with missing lines	Patch %	Lines
app/core/Engine/Engine.ts	0.00%	1 Missing ⚠️
app/util/smart-transactions/smart-publish-hook.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12465      +/-   ##
==========================================
+ Coverage   56.41%   57.03%   +0.62%     
==========================================
  Files        1797     1814      +17     
  Lines       40586    40858     +272     
  Branches     5097     5162      +65     
==========================================
+ Hits        22896    23304     +408     
+ Misses      16134    15970     -164     
- Partials     1556     1584      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tommasini]

Would be very nice to have some recordings in the PR description