fix: snaps text input does not trim whitespace #14270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Cross
added
No QA Needed
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
FrederikBolding
requested changes
Mar 27, 2025
Comment on lines
+64
to
+67
| if (trimmedText !== value) { | ||
| setValue(trimmedText); | ||
| handleInputChange(name, trimmedText, form); | ||
| } |
Member
There was a problem hiding this comment.
I left a comment on the issue about this too: I'm not convinced this is a Snaps platform problem, SnapUIInput is a general purpose component and the Snap can always trim the value it gets if it wants.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user copy and pastes a wallet address, they may occasionally copy and paste whitespace in the process. The Text Input will then give a warning to the user stating the "Solana address is invalid", when in reality it's just a whitespace issue.
This PR addresses the issue by trimming the whitespace on blur so the user most likely won't see the error as it will disappear once they press outside of the text input.
Related issues
Fixes: MetaMask/snaps#3257
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-27.at.16.17.48.mp4
Pre-merge author checklist
Pre-merge reviewer checklist