You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should have no functional changes, everything should work the same way.
Check out this branch and go through the setup steps to load the app onto your device or emulator.
Create an account if necessary.
Open the wallet to go the home screen. You should see no errors in your local console.
Try to switch the network. You should see no errors.
Try to send a transaction. You should see no errors.
Open the browser, go to docs.metamask.io, tap the hamburger menu, go to Wallet API, tap the menu again, go to JSON-RPC API, tap the menu again, go to wallet_addEthereumChain.
Click on "Connect MetaMask".
Scroll down and run the request (which should add Gnosis). Accept the approval.
You should get a modal saying that Gnosis has been switched to. You should not see any errors in your local terminal.
Screenshots/Recordings
(No screenshots/recordings, as everything should work the same way.)
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Right now this PR is using a preview build of network-controller to verify that there are no more bugs with the package.
If we can get this PR to pass, then next steps are to make a new release of network-controller and then bump the version on this PR to a non-preview build. Then I can open up this PR for proper review. I will also update the PR description and testing steps.
These upgrades support the RPC failover and MegaETH initiatives.
The patch is no longer needed because the changes there have been
integrated into `network-controller`.
mcmire
changed the title
chore: WIP - Bump network-controller to v23.1.0
chore: Bump network-controller to 23.2.0, controller-utils to 11.7.0
Apr 2, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metamaskbot
added
the
team-wallet-framework-deprecated
mcmire
changed the title
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
github-merge-queue
bot
removed this pull request from the merge queue due to a manual request
Description
These upgrades support the RPC failover and MegaETH initiatives.
The patch is no longer needed because the changes there have been
integrated into
network-controller.Related issues
Unblocks #14139, and other initiatives.
Manual testing steps
This PR should have no functional changes, everything should work the same way.
docs.metamask.io, tap the hamburger menu, go to Wallet API, tap the menu again, go to JSON-RPC API, tap the menu again, go towallet_addEthereumChain.Screenshots/Recordings
(No screenshots/recordings, as everything should work the same way.)
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist