chore: bump controllers to Core v343 [WIP] #14292

mathieuartu · 2025-03-28T08:04:13Z

Description

This PR bumps @metamask/keyring-controller from ^19.2.2 to ^21.0.1
It also bumps packages that have @metamask/keyring-controller version ^21.0.0 as a peer dependency:

@metamask/accounts-controller to ^27.0.0
@metamask/approval-controller to ^7.1.3
@metamask/assets-controller to ^55.0.1
@metamask/bridge-controller to ^11.0.0
@metamask/bridge-status-controller to ^10.0.0
@metamask/controller-utils to ^11.6.0
@metamask/gas-fee-controller to ^23.0.0
@metamask/json-rpc-middleware-stream to ^8.0.7
@metamask/multichain-network-controller to ^0.3.0
@metamask/multichain-transactions-controller to ^0.8.0
@metamask/network-controller to ^23.1.0
@metamask/notification-services-controller to ^5.0.1
@metamask/phishing-controller to ^12.4.1
@metamask/preferences-controller to ^17.0.0
@metamask/profile-sync-controller to ^11.0.0
@metamask/selected-network-controller to ^22.0.0
@metamask/signature-controller to ^25.0.0
@metamask/transaction-controller to ^52.1.0

Related issues

(List WIP)
Fixes:

Manual testing steps

No manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-28T08:04:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-03-28T08:05:52Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@ethersproject/abstract-provider@5.8.0	Transitive: network	`+3`	329 kB	ricmoo
npm/@ethersproject/abstract-signer@5.8.0	None	`0`	82.2 kB	ricmoo
npm/@ethersproject/address@5.8.0	None	`+4`	333 kB	ricmoo
npm/@ethersproject/base64@5.8.0	None	`0`	11.3 kB	ricmoo
npm/@ethersproject/basex@5.8.0	None	`0`	30.1 kB	ricmoo
npm/@ethersproject/constants@5.8.0	None	`0`	18.7 kB	ricmoo
npm/@ethersproject/hash@5.8.0	None	`+2`	407 kB	ricmoo
npm/@ethersproject/hdnode@5.8.0	None	`0`	80.7 kB	ricmoo
npm/@ethersproject/json-wallets@5.8.0	None	`+1`	2.56 MB	ricmoo
npm/@ethersproject/pbkdf2@5.8.0	None	`0`	17.4 kB	ricmoo
npm/@ethersproject/random@5.8.0	None	`0`	17.3 kB	ricmoo
npm/@ethersproject/sha2@5.8.0	None	`0`	21.7 kB	ricmoo
npm/@ethersproject/signing-key@5.8.0	None	`0`	248 kB	ricmoo
npm/@ethersproject/wallet@5.8.0	None	`0`	55.2 kB	ricmoo
npm/@ethersproject/wordlists@5.8.0	None	`0`	390 kB	ricmoo
npm/@metamask/accounts-controller@24.1.0 ➜ 27.0.0	Transitive: network	`+2`	1.14 MB	metamaskbot
npm/@metamask/assets-controllers@51.0.2 ➜ 55.0.1	None	`+5`	3.8 MB	metamaskbot
npm/@metamask/bridge-controller@7.0.0 ➜ 11.0.0	None	`0`	445 kB	metamaskbot
npm/@metamask/bridge-status-controller@7.0.0 ➜ 10.0.0	None	`+1`	540 kB	metamaskbot
npm/@metamask/eth-json-rpc-infura@10.0.0 ➜ 10.1.0	None	`0`	57.9 kB	mcmire
npm/@metamask/eth-json-rpc-middleware@15.2.0 ➜ 15.3.0	None	`0`	196 kB	gudahtt
npm/@metamask/eth-snap-keyring@11.1.0 ➜ 12.1.0	None	`+4`	2.9 MB	metamaskbot
npm/@metamask/gas-fee-controller@22.0.3 ➜ 23.0.0	None	`0`	224 kB	metamaskbot
npm/@metamask/keyring-controller@19.2.2, 21.0.0 ➜ 21.0.1	Transitive: environment	`+2`	713 kB	metamaskbot
npm/@metamask/multichain-network-controller@0.1.1 ➜ 0.3.0	None	`0`	111 kB	metamaskbot
npm/@metamask/multichain-transactions-controller@0.7.2 ➜ 0.8.0	None	`0`	94.1 kB	metamaskbot
npm/@metamask/network-controller@22.2.1 ➜ 23.1.0	None	`0`	866 kB	metamaskbot
npm/@metamask/notification-services-controller@2.0.0 ➜ 5.0.1	None	`0`	1.38 MB	metamaskbot
npm/@metamask/polling-controller@13.0.0	None	`0`	99.3 kB	metamaskbot
npm/@metamask/preferences-controller@15.0.1 ➜ 17.0.0	None	`0`	141 kB	metamaskbot
npm/@metamask/profile-sync-controller@10.1.0 ➜ 11.0.0	None	`0`	1.14 MB	metamaskbot
npm/@metamask/selected-network-controller@21.0.0 ➜ 22.0.0	None	`0`	137 kB	metamaskbot
npm/@metamask/signature-controller@23.1.0 ➜ 27.0.0	None	`0`	316 kB	metamaskbot
npm/@metamask/transaction-controller@45.0.0 ➜ 52.1.0	None	`0`	2.45 MB	metamaskbot

🚮 Removed packages: npm/@metamask/eth-simple-keyring@8.1.1, npm/@metamask/keyring-internal-api@4.0.3

View full report↗︎

github-actions · 2025-03-28T08:06:33Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 923000c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53c17739-06ff-4309-832f-c1fa8fc684d5

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-03-28T09:47:18Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 01acd69
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6738606-ab7d-4503-8aec-f3b97bcf09a9

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-03-28T11:35:24Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8edb5c1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab05f755-26dc-48f6-a2fb-dec4beabd9d3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini · 2025-03-28T12:45:20Z

Heyy, I believe we do need to bump more packages that are dependent on the keyring controller version!
Example: accounts-controllers, assets-controllers, notifications-services-controller , preferences-controller, signature-controller,

OGPoyraz

Confirmation changes LGTM

github-actions · 2025-03-28T14:24:17Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6a15fb2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e4127633-3246-4af6-91d6-6fb3fb9377ef

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-03-28T14:28:34Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

EtherWizard33 · 2025-03-28T16:25:55Z

app/components/Views/NetworkSelector/RpcSelectionModal/RpcSelectionModal.test.tsx

        networkClientId: NETWORK_CHAIN_ID.MAINNET,
        type: RpcEndpointType.Custom,
        name: 'Ethereum',
+        failoverUrls: [],


looks like a simple chainge with default value added to test, could be nice to know the usage of failoverUrls, its the first time i hear about them, also considering like it doesnt seem like its an optional value

EtherWizard33

approved for wallet-ux file, looks like just a mock uipdate to unit test for the network select rpc selection

sahar-fehri · 2025-03-28T16:40:43Z

Hey @mathieuartu , i had this PR to upgrade assets-controllers to v55.0.1 and handle to the introduced changes to detectNfts fct, do you think my PR can get in first?

chore: bump keyring-controller to ^21.0.1

923000c

mathieuartu added the team-identity-deprecated DEPRECATED: team no longer exists label Mar 28, 2025

mathieuartu self-assigned this Mar 28, 2025

mathieuartu added Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. labels Mar 28, 2025

mathieuartu added 2 commits March 28, 2025 09:06

fix: yarn dedupe

426e43e

fix: update withKeyring occurrences

01acd69

mathieuartu added Run Smoke E2E and removed Run Smoke E2E labels Mar 28, 2025

mathieuartu changed the title ~~chore: bump keyring-controller to ^21.0.1~~ chore: bump @metamask/keyring-controller to ^21.0.1 Mar 28, 2025

mathieuartu added 2 commits March 28, 2025 11:53

fix: test coverage

ea143a4

fix: test coverage

8edb5c1

mathieuartu added Run Smoke E2E and removed Run Smoke E2E labels Mar 28, 2025

metamaskbot added the bitrise-result-ready label Mar 28, 2025

github-actions bot removed the bitrise-result-ready label Mar 28, 2025

mathieuartu marked this pull request as ready for review March 28, 2025 12:31

mathieuartu requested a review from a team as a code owner March 28, 2025 12:31

mathieuartu requested a review from a team March 28, 2025 12:31

mathieuartu requested a review from a team as a code owner March 28, 2025 12:31

OGPoyraz previously approved these changes Mar 28, 2025

View reviewed changes

mathieuartu marked this pull request as draft March 28, 2025 13:17

mathieuartu changed the title ~~chore: bump @metamask/keyring-controller to ^21.0.1~~ chore: bump controllers to core 343.0.0 [WIP] Mar 28, 2025

chore: bump packages that have keyring-controller 21.0.0 as peerDep

78bf2fe

mathieuartu added 2 commits March 28, 2025 15:01

fix: downgrade accounts-controller to 26.0.0 + remove expect-errors

47c015f

fix: accounts-controller messenger allowedActions

e2681f3

mathieuartu changed the title ~~chore: bump controllers to core 343.0.0 [WIP]~~ chore: bump @metamask/keyring-controller to ^21.0.1 and align peer dependencies Mar 28, 2025

fix: notifications messenger UT

6a15fb2

mathieuartu added Run Smoke E2E and removed Run Smoke E2E labels Mar 28, 2025

Prithpal-Sooriya approved these changes Mar 28, 2025

View reviewed changes

mathieuartu marked this pull request as ready for review March 28, 2025 14:27

mathieuartu requested review from a team as code owners March 28, 2025 14:27

Prithpal-Sooriya previously approved these changes Mar 28, 2025

View reviewed changes

mathieuartu changed the title ~~chore: bump @metamask/keyring-controller to ^21.0.1 and align peer dependencies~~ chore: bump controllers to Core v343 Mar 28, 2025

fix: add core v343 bumps

01945ff

mathieuartu dismissed Prithpal-Sooriya’s stale review via 01945ff March 28, 2025 14:50

mathieuartu changed the title ~~chore: bump controllers to Core v343~~ chore: bump controllers to Core v343 [WIP] Mar 28, 2025

metamaskbot added the bitrise-result-ready label Mar 28, 2025

github-actions bot removed the bitrise-result-ready label Mar 28, 2025

mathieuartu added 2 commits March 28, 2025 16:10

fix: update network-controller patch

ee425a4

fix: lint errors WIP

29fd2ec

mathieuartu requested review from a team as code owners March 28, 2025 15:27

EtherWizard33 reviewed Mar 28, 2025

View reviewed changes

EtherWizard33 approved these changes Mar 28, 2025

View reviewed changes

infiniteflower approved these changes Mar 28, 2025

View reviewed changes

infiniteflower self-requested a review March 28, 2025 19:57

mathieuartu closed this Apr 2, 2025

github-actions bot locked and limited conversation to collaborators Apr 2, 2025

Uh oh!

chore: bump controllers to Core v343 [WIP] #14292

chore: bump controllers to Core v343 [WIP] #14292

Uh oh!

Conversation

mathieuartu commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

socket-security bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Mar 28, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Mar 28, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

tommasini commented Mar 28, 2025

Uh oh!

OGPoyraz left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 28, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Mar 28, 2025

Quality Gate passed

Uh oh!

EtherWizard33 Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

EtherWizard33 left a comment

Choose a reason for hiding this comment

Uh oh!

sahar-fehri commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mathieuartu commented Mar 28, 2025 •

edited

Loading

socket-security bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Mar 28, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Mar 28, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Mar 28, 2025 •

edited by metamaskbot

Loading