Skip to content

fix: google cancel login in android cp-7.53.0 cp-7.54.0#18596

Merged
ieow merged 1 commit into
mainfrom
feat/google-cancel-login
Aug 22, 2025
Merged

fix: google cancel login in android cp-7.53.0 cp-7.54.0#18596
ieow merged 1 commit into
mainfrom
feat/google-cancel-login

Conversation

@ieow
Copy link
Copy Markdown
Contributor

@ieow ieow commented Aug 22, 2025

Description

Sentry Error capture screen appear when user cancel google login ( when user only have one google account).

This is due to google throw different error message when user cancel when user have one account and multiple account.

fixed by lower cases the error message and regex keyword to determine the error is due to user cancel

Error throwed by google

  • when only one account login in device
    Cancelled by user

  • when have multiple account in device
    User cancelled the selector

Changelog

CHANGELOG entry:

Related issues

Fixes:
#18597
#18597

Manual testing steps

Feature: Cancel google login in android

  Scenario: user try google login flow in android
    Given user have only 1 google account sign in device

    When user cancel the google login flow
    Then there will be no sentry capture screen

Screenshots/Recordings

Before

After

Video.2025-08-22.at.1.05.41.PM.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Aug 22, 2025
@ieow ieow marked this pull request as ready for review August 22, 2025 05:07
@ieow ieow requested a review from a team as a code owner August 22, 2025 05:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 22, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f7a6a7c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ad8f57e5-e4a3-43c9-bdb0-3dd91506d0ae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

@ieow ieow enabled auto-merge August 22, 2025 05:35
@ieow ieow self-assigned this Aug 22, 2025
@nakulmk nakulmk added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Aug 22, 2025
@nakulmk nakulmk changed the title fix: google cancel login in android fix: google cancel login in android cp-7.53 Aug 22, 2025
@nakulmk nakulmk changed the title fix: google cancel login in android cp-7.53 fix: google cancel login in android cp-7.53.0 Aug 22, 2025
Copy link
Copy Markdown
Contributor

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LeVinhGithub LeVinhGithub added the QA Passed QA testing has been completed and passed label Aug 22, 2025
@LeVinhGithub
Copy link
Copy Markdown
Contributor

lgtm

@ieow ieow added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit 939690e Aug 22, 2025
95 of 105 checks passed
@ieow ieow deleted the feat/google-cancel-login branch August 22, 2025 07:34
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 22, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 22, 2025
@himanshuchawla009 himanshuchawla009 removed the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 22, 2025
@ieow ieow changed the title fix: google cancel login in android cp-7.53.0 fix: google cancel login in android cp-7.53.0 cp-7.54.0 Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.53.0 Issue or pull request that will be included in release 7.53.0 size-XS team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants