Skip to content

chore: added fingerprint status check to skip build & cache#23697

Merged
sethkfman merged 1 commit into
mainfrom
chore/add-fingerprint-check
Dec 5, 2025
Merged

chore: added fingerprint status check to skip build & cache#23697
sethkfman merged 1 commit into
mainfrom
chore/add-fingerprint-check

Conversation

@sethkfman
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman commented Dec 4, 2025

Description

This PR updates the Android E2E build step and applies an if check on the caching and build step if the fingerprint finds a hit.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Screenshot 2025-12-04 at 3 22 37 PM

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit e5e31e2. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Dec 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

The change modifies .github/workflows/build-android-e2e.yml to add conditional execution (if: steps.apk-cache-restore.outputs.cache-hit != 'true') to two steps: "Cache Gradle dependencies" and "Build Android E2E APKs". This is a pure CI build optimization that skips redundant steps when APK cache is already available.

Key observations:

  1. No application code changes - Only CI workflow file modified
  2. Build optimization only - The changes skip expensive build steps when cached APKs exist
  3. Existing cache-hit handling - The workflow already has a "Repack APK with JS updates" step that runs when cache-hit is true, so this change just prevents the full build from running unnecessarily
  4. No test logic changes - No modifications to E2E test code, fixtures, or test infrastructure
  5. Straightforward conditional logic - Simple boolean condition checking cache status

This is a low-risk CI efficiency improvement. The APK building process remains unchanged when cache misses occur, and the caching logic has always intended to skip the full build on cache hits. No E2E tests need to run specifically for this change as it doesn't affect any application functionality or test behavior.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added this pull request to the merge queue Dec 4, 2025
Merged via the queue into main with commit e065523 Dec 5, 2025
111 checks passed
@sethkfman sethkfman deleted the chore/add-fingerprint-check branch December 5, 2025 00:03
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 5, 2025
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants