Skip to content

chore: Remove redesigned_confirmation from ui_customization property#23975

Merged
dan437 merged 1 commit into
mainfrom
confirmations-event-cleanup
Dec 12, 2025
Merged

chore: Remove redesigned_confirmation from ui_customization property#23975
dan437 merged 1 commit into
mainfrom
confirmations-event-cleanup

Conversation

@dan437

@dan437 dan437 commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Description

We no longer need to track if a confirmations is redesign so we can delete this code. Similar thing was done in the extension: MetaMask/metamask-extension#38706

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6075

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes 'redesigned_confirmation' from metrics and conditionally includes only Blockaid-provided ui_customizations; updates related tests and ERC20 tracking event.

  • Metrics (signatures)
    • useSignatureMetrics: stop appending redesigned_confirmation; only set ui_customizations when non-empty and pass through Blockaid values unchanged.
    • Refactors analytics params construction accordingly.
  • Tests
    • Update useSignatureMetrics.test.ts expectations to remove redesigned_confirmation and reflect conditional ui_customizations.
  • ERC20 Tracking
    • useTrackERC20WithoutDecimalInformation: remove ui_customizations from INCOMPLETE_ASSET_DISPLAYED event properties.

Written by Cursor Bugbot for commit 93c9ece. This will update automatically on new commits. Configure here.

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437 dan437 requested a review from a team as a code owner December 12, 2025 12:49
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 12, 2025
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmationsRedesigned
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The changes are purely analytics/metrics-related modifications in the confirmations hooks:

  1. useSignatureMetrics.ts: Removes hardcoded 'redesigned_confirmation' from ui_customizations array in analytics params. Now only includes ui_customizations if there are actual customizations from blockaid metrics.

  2. useSignatureMetrics.test.ts: Updates test expectations to match the new behavior.

  3. useTrackERC20WithoutDecimalInformation.ts: Removes ui_customizations property from ERC20 decimal tracking analytics event.

These changes:

  • Only affect what data is sent to analytics events
  • Do not change any functional UI behavior
  • Do not affect user-facing features
  • Are limited to the confirmations flow (signature requests and typed sign simulations)

The risk is low because:

  • No functional code paths are changed
  • The changes are well-tested (test file updated accordingly)
  • Analytics data changes don't affect app behavior

SmokeConfirmationsRedesigned is selected as it covers the confirmation flows where these hooks are used, ensuring the signature and typed sign confirmation flows still work correctly after these analytics changes.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@dan437 dan437 enabled auto-merge December 12, 2025 14:35
@dan437 dan437 added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 901b815 Dec 12, 2025
175 of 177 checks passed
@dan437 dan437 deleted the confirmations-event-cleanup branch December 12, 2025 14:57
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 12, 2025
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants