chore: Remove redesigned_confirmation from ui_customization property#23975
Conversation
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes are purely analytics/metrics-related modifications in the confirmations hooks:
These changes:
The risk is low because:
SmokeConfirmationsRedesigned is selected as it covers the confirmation flows where these hooks are used, ensuring the signature and typed sign confirmation flows still work correctly after these analytics changes. |
|



Description
We no longer need to track if a confirmations is redesign so we can delete this code. Similar thing was done in the extension: MetaMask/metamask-extension#38706
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6075
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes 'redesigned_confirmation' from metrics and conditionally includes only Blockaid-provided
ui_customizations; updates related tests and ERC20 tracking event.useSignatureMetrics: stop appendingredesigned_confirmation; only setui_customizationswhen non-empty and pass through Blockaid values unchanged.useSignatureMetrics.test.tsexpectations to removeredesigned_confirmationand reflect conditionalui_customizations.useTrackERC20WithoutDecimalInformation: removeui_customizationsfromINCOMPLETE_ASSET_DISPLAYEDevent properties.Written by Cursor Bugbot for commit 93c9ece. This will update automatically on new commits. Configure here.