chore: remove legacy confirmation code#24929
Conversation
dec6710 to
29c8f08
Compare
cortisiko
left a comment
There was a problem hiding this comment.
Can we move https://github.com/MetaMask/metamask-mobile/blob/chore/remove-legacy-confirmation-e2e-tests/e2e/specs/confirmations/transaction-pay.spec.ts to the confirmation redesign folder and get rid of the confirmations folder? There is only 1 test in there.
c56d7b4 to
64a9b97
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24929 +/- ##
==========================================
- Coverage 79.93% 74.80% -5.14%
==========================================
Files 4257 4212 -45
Lines 109292 107162 -2130
Branches 22875 22754 -121
==========================================
- Hits 87359 80159 -7200
- Misses 15882 21168 +5286
+ Partials 6051 5835 -216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the feedback @cortisiko ! |
64a9b97 to
dd607fb
Compare
e45d9f7
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|



Description
Remove all legacy confirmation related code from the codebase.
List of actions:
app/components/Views/confirmations/legacy/components. We will eventually remove/replace these components.transactionreducer and their actions removed.signatureRequestreducer and their actions removed.securityAlertsto store security alerts for both transaction and signature confirmations.app/components/Nav/Main/RootRPCMethodsUI.jssignificantly simplified - removed unusued code and property connectors, we can now plan to make it more stable by doing TS conversion.confirmations_redesignfeature flag and all it's references removed, no moreuseConfirmationsRedesignhook.Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5233
Manual testing steps
Screenshots/Recordings
Before
After
Hardware Wallet Recordings (Updated on 27 January 20:02)
Ledger send flow
ledger-send-flow.mp4
Ledger swap flow
ledger-swap-flow.mp4
QR Wallet send flow
qr-wallet-send-flow.mp4
QR Wallet swap flow
qr-wallet-swap-flow.mp4
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes legacy confirmation system and fully adopts the redesigned confirmations, simplifying navigation and data flow.
transaction/signatureRequestactions/reducer; introduces unifiedsecurityAlertsstorage and updates hooks (useSecurityAlertResponse) to read by confirmation IDQRSigningTransactionModal(added to navigation) and routes all QR signing from Transactions and unified tx actions to this modalRootRPCMethodsUI(drops Redux connectors/legacy transaction prep) and relies on redesigned confirmation routing viaConfirmRootuseConfirmationRedesignEnabledand related feature flags; staking/earn flows default to redesigned paths; updates tests accordinglynewAssetTransactionusage across UI (Wallet, Asset/Collectible views, QR scanner); send flow now navigates directly via redesigned hookscomponents/blockaid-bannerand updates imports/usages across confirmation UIsWritten by Cursor Bugbot for commit e45d9f7. This will update automatically on new commits. Configure here.