chore(runway): cherry-pick fix(predict): cp-7.63.0 override team colors for Super Bowl#25208
Merged
joaoloureirop merged 1 commit intorelease/7.63.0from Jan 26, 2026
Merged
Conversation
…rs for Super Bowl (#25204) ## **Description** Override team colors for Super Bowl teams to ensure correct branding display. The Polymarket API returns incorrect team colors for the New England Patriots and Seattle Seahawks, so we apply manual overrides when caching team data. **Changes:** - Added `TEAM_COLOR_OVERRIDES` constant with corrected colors for NE (Patriots blue) and SEA (Seahawks green) - Applied color overrides during team cache population ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/PRED-545 ## **Manual testing steps** ```gherkin Feature: Predict team colors display Scenario: user views Super Bowl market with correct team colors Given user has navigated to a Super Bowl prediction market When user views the market details Then Patriots (NE) should display with color #1D4E9B And Seahawks (SEA) should display with color #69BE28 ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> <img width="373" height="772" alt="Screenshot 2026-01-26 at 9 50 42 AM" src="https://github.com/user-attachments/assets/0e9cde1a-2179-491c-b592-b55ea260ded7" /> <img width="367" height="764" alt="Screenshot 2026-01-26 at 9 50 29 AM" src="https://github.com/user-attachments/assets/5558cf8f-86b9-4fa6-8125-dc85a9c51d7a" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Ensures correct team branding colors in Predict for Polymarket teams. > > - Introduces `TEAM_COLOR_OVERRIDES` with corrected hex colors for `ne` and `sea` > - Applies overrides in `TeamsCache.fetchAndCacheTeams` when populating the league cache > - Adds file-level ESLint disable for hex color tokens > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ad4835d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.63.0) All E2E tests pre-selected. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| for (const team of teams) { | ||
| if (team.abbreviation) { | ||
| team.color = TEAM_COLOR_OVERRIDES[team.abbreviation] ?? team.color; |
There was a problem hiding this comment.
Case-sensitive key lookup prevents color override from working
High Severity
The TEAM_COLOR_OVERRIDES constant uses lowercase keys (ne, sea), but team.abbreviation from the Polymarket API is uppercase (NE, SEA). The lookup TEAM_COLOR_OVERRIDES[team.abbreviation] returns undefined because JavaScript object keys are case-sensitive. The override falls back to the original team.color via the nullish coalescing operator, defeating the entire purpose of this fix.
Additional Locations (1)
|
joaoloureirop
approved these changes
Jan 26, 2026
metamaskbot
added
the
release-7.63.0
Collaborator
|
No release label on PR. Adding release label release-7.63.0 on PR, as PR was cherry-picked in branch 7.63.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Override team colors for Super Bowl teams to ensure correct branding
display. The Polymarket API returns incorrect team colors for the New
England Patriots and Seattle Seahawks, so we apply manual overrides when
caching team data.
Changes:
TEAM_COLOR_OVERRIDESconstant with corrected colors for NE(Patriots blue) and SEA (Seahawks green)
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/PRED-545
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Ensures correct branding colors for specific teams when ingesting Polymarket data.
TEAM_COLOR_OVERRIDESwith NE#1D4E9Band SEA#69BE28TeamsCache.fetchAndCacheTeamsbefore storing teams in cacheWritten by Cursor Bugbot for commit 4640b44. This will update automatically on new commits. Configure here.
903f214