Skip to content

fix: update selectedGasFeeToken when payment token is selected for ga…#25273

Merged
joaoloureirop merged 2 commits intorelease/7.62.1from
cherry-pick-7-62-1-f253ede
Jan 27, 2026
Merged

fix: update selectedGasFeeToken when payment token is selected for ga…#25273
joaoloureirop merged 2 commits intorelease/7.62.1from
cherry-pick-7-62-1-f253ede

Conversation

@pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Jan 27, 2026

…sless flow cp-7.62.1

cherry-pick of #25209

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Improves gasless deposit handling and simplifies fee token plumbing.

  • Updates useTransactionPayToken to set selectedGasFeeToken (and isGasFeeTokenIgnoredIfBalance) when a pay token is chosen for predictDeposit, with tests
  • Removes gasFeeToken usage across Predict/Perps deposit flows: deletes field from provider types, Polymarket provider return, controller submissions, and related tests
  • Adds a guard in PerpsController.depositWithConfirmation to throw when NetworkController.findNetworkClientIdByChainId returns no client
  • Test scaffolding updated (Engine mocks, transaction submission) accordingly

Written by Cursor Bugbot for commit 5126914. This will update automatically on new commits. Configure here.

@pedronfigueiredo pedronfigueiredo self-assigned this Jan 27, 2026
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner January 27, 2026 14:58
@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Jan 27, 2026
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners January 27, 2026 14:58
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.62.1)

All E2E tests pre-selected.

View GitHub Actions results

@pedronfigueiredo pedronfigueiredo added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Jan 27, 2026
@sonarqubecloud
Copy link

@joaoloureirop joaoloureirop enabled auto-merge (squash) January 27, 2026 20:16
@joaoloureirop joaoloureirop merged commit 3e0a296 into release/7.62.1 Jan 27, 2026
97 of 98 checks passed
@joaoloureirop joaoloureirop deleted the cherry-pick-7-62-1-f253ede branch January 27, 2026 20:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2026
@metamaskbot metamaskbot added the release-7.62.1 Issue or pull request that will be included in release 7.62.1 label Jan 30, 2026
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.62.1 on PR, as PR was added to branch 7.62.1 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.62.1 Issue or pull request that will be included in release 7.62.1 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants