Skip to content

chore(runway): cherry-pick fix: Android ANR bug#25596

Merged
joaoloureirop merged 1 commit intorelease/7.63.1from
cherry-pick-7-63-1-b566864
Feb 3, 2026
Merged

chore(runway): cherry-pick fix: Android ANR bug#25596
joaoloureirop merged 1 commit intorelease/7.63.1from
cherry-pick-7-63-1-b566864

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Feb 3, 2026

Description

Fix: Prevent crash caused by Notifee BlockStateBroadcastReceiver during
cold start

Summary

Fixes a crash that occurs when notification permission changes trigger
Notifee's BlockStateBroadcastReceiver before React Native is fully
initialized during app cold start.

Solution

Disable Notifee's BlockStateBroadcastReceiver by adding an override in
AndroidManifest.xml. This is the most light weight solution.

Changes (Background Tracking Only):
User Changes Settings OUTSIDE the App
Before (with receiver enabled):

  1. User closes MetaMask
  2. User goes to Android Settings → Apps → MetaMask → Notifications
  3. User toggles "Allow notifications" OFF
  4. BlockStateBroadcastReceiver fires immediately
    5. MetaMask knows about the change (while app is closed)

After (with receiver disabled):

  1. User closes MetaMask
  2. User goes to Android Settings → Apps → MetaMask → Notifications
  3. User toggles "Allow notifications" OFF
  4. Nothing happens in the background
    5. MetaMask detects the change next time app opens

Builds to test:
Crash version:
https://app.bitrise.io/build/f78866d9-cb88-4789-8be0-dec2d7c18e20
Fixed version:
https://app.bitrise.io/build/cd177e81-6545-44ff-a20f-6c5ed11936b5?tab=artifacts

Changelog

CHANGELOG entry:Fix: Prevent crash caused by Notifee
BlockStateBroadcastReceiver during cold start

Related issues

Fixes: Fix: Prevent crash caused by Notifee BlockStateBroadcastReceiver
during cold start

Manual testing steps

Scenario: App launches successfully when notification permission is disabled in Android Settings during cold start (After Fix)
  Given the MetaMask app is completely closed
  When I open Android Settings
  And I navigate to "Apps""MetaMask""Notifications"
  And I toggle "Allow notifications" to OFF
  And I return to the home screen
  And I tap the MetaMask app icon to launch it
  Then the app should launch successfully
  And I should not see any crash dialogs
  And I should see the wallet home screen

Screenshots/Recordings

Before

crashed

After

no crash

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk manifest-only change; main impact is disabling Notifee’s background receiver so notification permission toggles won’t be detected until next app launch.

Overview
Prevents a cold-start crash/ANR by disabling Notifee’s app.notifee.core.BlockStateBroadcastReceiver via an AndroidManifest.xml override.

This removes the receiver from the merged manifest (and marks it enabled="false"), trading off background detection of Android notification permission changes while the app is closed for startup stability.

Written by Cursor Bugbot for commit e00915c. This will update automatically on new commits. Configure here.


Co-authored-by: metamaskbot metamaskbot@users.noreply.github.com b566864

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

Fix: Prevent crash caused by Notifee BlockStateBroadcastReceiver during
cold start

Fixes a crash that occurs when notification permission changes trigger
Notifee's `BlockStateBroadcastReceiver` before React Native is fully
initialized during app cold start.

Disable Notifee's `BlockStateBroadcastReceiver` by adding an override in
`AndroidManifest.xml`. This is the most light weight solution.

Changes (Background Tracking Only):
User Changes Settings OUTSIDE the App
Before (with receiver enabled):
1. User closes MetaMask
2. User goes to Android Settings → Apps → MetaMask → Notifications
3. User toggles "Allow notifications" OFF
4. BlockStateBroadcastReceiver fires immediately
**5. MetaMask knows about the change (while app is closed)**

After (with receiver disabled):
1. User closes MetaMask
2. User goes to Android Settings → Apps → MetaMask → Notifications
3. User toggles "Allow notifications" OFF
4. Nothing happens in the background
**5. MetaMask detects the change next time app opens**

Builds to test:
Crash version:
https://app.bitrise.io/build/f78866d9-cb88-4789-8be0-dec2d7c18e20
Fixed version:
https://app.bitrise.io/build/cd177e81-6545-44ff-a20f-6c5ed11936b5?tab=artifacts

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:Fix: Prevent crash caused by Notifee
BlockStateBroadcastReceiver during cold start

Fixes: [Fix: Prevent crash caused by Notifee BlockStateBroadcastReceiver
during cold start
](#25524)

```gherkin
Scenario: App launches successfully when notification permission is disabled in Android Settings during cold start (After Fix)
  Given the MetaMask app is completely closed
  When I open Android Settings
  And I navigate to "Apps" → "MetaMask" → "Notifications"
  And I toggle "Allow notifications" to OFF
  And I return to the home screen
  And I tap the MetaMask app icon to launch it
  Then the app should launch successfully
  And I should not see any crash dialogs
  And I should see the wallet home screen
```

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

![crashed](https://github.com/user-attachments/assets/5031a720-dec4-4b4a-9daa-3fc0f19a9847)

![no
crash](https://github.com/user-attachments/assets/7be5a943-e477-4379-8678-994584e116a6)

<!-- [screenshots/recordings] -->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Disabling an Android broadcast receiver can change
notification-permission change handling while the app is closed;
otherwise changes are limited to build number bumps.
>
> **Overview**
> Prevents an Android cold-start crash by **disabling Notifee’s**
`app.notifee.core.BlockStateBroadcastReceiver` via an
`AndroidManifest.xml` override, so it no longer runs before React Native
is initialized.
>
> Also bumps the shared build/version code from `3418` to `3607` across
Android (`build.gradle`), iOS (`CURRENT_PROJECT_VERSION`), and CI
(`bitrise.yml`).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c944618. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.63.1)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@joaoloureirop joaoloureirop merged commit 04c476e into release/7.63.1 Feb 3, 2026
141 of 143 checks passed
@joaoloureirop joaoloureirop deleted the cherry-pick-7-63-1-b566864 branch February 3, 2026 22:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.63.1 on PR, as PR was cherry-picked in branch 7.63.1.

@metamaskbot metamaskbot added the release-7.63.1 Issue or pull request that will be included in release 7.63.1 label Feb 5, 2026
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.63.1 on PR, as PR was cherry-picked in branch 7.63.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.63.1 Issue or pull request that will be included in release 7.63.1 size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants