Skip to content

chore(runway): cherry-pick feat: cp-7.64.0 MUSD-279 moved Earn CTAs to be next to asset name#25600

Merged
joaoloureirop merged 1 commit intorelease/7.64.0from
runway-cherry-pick-7.64.0-1770143134
Feb 3, 2026
Merged

chore(runway): cherry-pick feat: cp-7.64.0 MUSD-279 moved Earn CTAs to be next to asset name#25600
joaoloureirop merged 1 commit intorelease/7.64.0from
runway-cherry-pick-7.64.0-1770143134

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Feb 3, 2026

Description

Moves the "Earn %" CTA for Ethereum and Tron to be next to the asset
name. This fix is needed because large token balances are causing the
"Earn %" CTA to clip into the percentage changed text.

Changelog

CHANGELOG entry: moved the "Earn %" CTA for Ethereum and Tron to be next
to the asset name

Related issues

Fixes: MUSD-279: Move the Earn CTAs next to ETH and Tron contextually
next to the asset
name's

Manual testing steps

Feature: Earn call-to-action placement in token list

  Scenario: user sees stake call-to-action next to token name
    When user views ETH and the token in the token list
    When user has non-zero token balance
    Then a Stake call-to-action is displayed inline next to the token name

Screenshots/Recordings

Before

Earn CTA collides with the percentage changed text for large token
balances.

After

Screenshot 2026-02-02 at 3 50 50 PM
Screenshot 2026-02-02 at 3 51 07 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk UI-only layout change within TokenListItem; main risk is minor visual regressions/alignment issues across devices and long names/labels.

Overview
Moves the token-list Earn/Stake call-to-action (renderEarnCta()) from the balance/percentage row to sit inline next to the asset name.

Adds a new assetNameContainer row style to keep the name/label and CTA aligned, preventing the CTA from overlapping/clipping with the secondary balance text for large balances.

Written by Cursor Bugbot for commit cc21dce. This will update automatically on new commits. Configure here.

ba206df

…o be next to asset name (#25545)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Moves the "Earn %" CTA for Ethereum and Tron to be next to the asset
name. This fix is needed because large token balances are causing the
"Earn %" CTA to clip into the percentage changed text.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: moved the "Earn %" CTA for Ethereum and Tron to be next
to the asset name

## **Related issues**

Fixes: [MUSD-279: Move the Earn CTAs next to ETH and Tron contextually
next to the asset
name's](https://consensyssoftware.atlassian.net/browse/MUSD-279)

## **Manual testing steps**

```gherkin
Feature: Earn call-to-action placement in token list

  Scenario: user sees stake call-to-action next to token name
    When user views ETH and the token in the token list
    When user has non-zero token balance
    Then a Stake call-to-action is displayed inline next to the token name
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->
Earn CTA collides with the percentage changed text for large token
balances.
### **After**

<!-- [screenshots/recordings] -->
<img width="454" height="81" alt="Screenshot 2026-02-02 at 3 50 50 PM"
src="https://github.com/user-attachments/assets/21a1671f-2d66-4017-bc2b-1c78fcfd4e02"
/>
<img width="454" height="81" alt="Screenshot 2026-02-02 at 3 51 07 PM"
src="https://github.com/user-attachments/assets/690691a3-ebf9-43ea-a8a8-5f298c66c3bd"
/>

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk UI-only layout change in `TokenListItem` that repositions the
Earn/Stake CTA; main risk is minor alignment/regression across different
token name lengths and badges.
> 
> **Overview**
> Moves the token list item Earn/Stake CTA (via `renderEarnCta()`) from
the secondary balance row to sit inline next to the asset name/label,
preventing it from colliding with large balance/percentage-change text.
> 
> Adds an `assetNameContainer` row wrapper style to align the name/label
and CTA horizontally.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
9de9bcc. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github bot requested a review from a team as a code owner February 3, 2026 18:25
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.64.0)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions bot added the size-S label Feb 3, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@joaoloureirop joaoloureirop enabled auto-merge (squash) February 3, 2026 22:13
@joaoloureirop joaoloureirop merged commit e180edc into release/7.64.0 Feb 3, 2026
155 of 157 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.64.0-1770143134 branch February 3, 2026 22:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
@metamaskbot metamaskbot added the release-7.64.0 Issue or pull request that will be included in release 7.64.0 label Feb 6, 2026
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.64.0 on PR, as PR was cherry-picked in branch 7.64.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants