chore(runway): cherry-pick fix: remove old erc-20 balances that fully get swapped#25899
Merged
joaoloureirop merged 1 commit intorelease/7.65.0from Feb 10, 2026
Merged
Conversation
) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Patch of this fix: MetaMask/core#7861 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix: remove old erc-20 balances that fully get swapped Fixes: [#incident-metamask-1453](https://consensys.slack.com/archives/C0AD7TXHKQS) ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> https://www.loom.com/share/243ad5b96abc4591bd3b51cc28d2e2d8 - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes token balance fetching/normalization logic via a Yarn patch, which can affect displayed balances and token cleanup after swaps; risk is moderate due to impact on core wallet state but scoped to balance results shaping. > > **Overview** > Applies a Yarn patch to `@metamask/assets-controllers` to prevent stale ERC-20 balances from lingering when the Accounts API omits a token (e.g., after fully swapping out). > > `TokenBalancesController` now passes a `getUserTokens` callback into `AccountsApiBalanceFetcher`, which tracks non-native token balances returned by the API and **emits explicit zero-balance results** for any user-tracked ERC-20 token missing from the API response so downstream state can clear it. The PR also pins the app’s `@metamask/assets-controllers` dependency to the patched `99.2.0` and updates lockfile/resolutions accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 223dbfd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.65.0) All E2E tests pre-selected. |
|
metamaskbot
added
the
release-7.65.0
Collaborator
|
No release label on PR. Adding release label release-7.65.0 on PR, as PR was cherry-picked in branch 7.65.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patch of this fix: MetaMask/core#7861
Changelog
CHANGELOG entry: fix: remove old erc-20 balances that fully get swapped
Related issues
Fixes:
#incident-metamask-1453
Manual testing steps
Screenshots/Recordings
Before
After
https://www.loom.com/share/243ad5b96abc4591bd3b51cc28d2e2d8
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Touches token balance fetching/normalization logic via a vendored patch, which could affect displayed balances if token tracking data or API responses differ from expectations.
Overview
Fixes stale ERC-20 balances after full swaps by patching
@metamask/assets-controllersso the Accounts API balance fetcher can derive the user’s tracked token list and emit explicit zero balance entries for tracked ERC-20s missing from the API response.Wires
TokenBalancesControllerto pass currentstate.tokenBalancesinto theAccountsApiBalanceFetcher, and updates app dependencies to use the patched@metamask/assets-controllers@99.2.0(with corresponding lockfile/resolution updates).Written by Cursor Bugbot for commit b6e90d7. This will update automatically on new commits. Configure here.
3cd7132