fix(predict): fix query invalidation logic in usePredictToastRegistrations

[matallui]

Description

Deposit and withdraw toast handlers were incorrectly invalidating positions and activity queries, causing unnecessary refetches. This change scopes those invalidations to only the claim type, where they are actually relevant. Balance and unrealized PnL queries remain invalidated for all types.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Predict query invalidations

  Scenario: Deposit completes without refetching positions/activity
    Given the user has a pending deposit transaction

    When the deposit transaction is confirmed
    Then balance and unrealized PnL queries are invalidated
    And positions and activity queries are NOT invalidated

  Scenario: Claim completes and refetches all relevant data
    Given the user has a pending claim transaction

    When the claim transaction is confirmed
    Then balance, unrealized PnL, positions, and activity queries are all invalidated

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low-risk change limited to React Query cache invalidation; it only reduces unnecessary refetches after deposit/withdraw confirmations and should not affect transaction execution.

Overview
Fixes usePredictToastRegistrations query invalidation so on confirmed transactions it always invalidates balance and unrealizedPnL, but only invalidates positions and activity when the transaction type is claim.

This prevents deposit/withdraw toast flows from triggering unnecessary positions/activity refetches while keeping claim-related data refresh behavior intact.

^{Written by Cursor Bugbot for commit e157a2e. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: @PerformancePredict
• Risk Level: medium
• AI Confidence: 85%

click to see 🤖 AI reasoning details

E2E Test Selection:
The change modifies usePredictToastRegistrations.tsx, a hook that handles toast notifications and query invalidation for Predict (Polymarket) transactions. The specific change alters the query invalidation logic:

1. Previously, when any transaction (deposit, withdraw, claim) was confirmed, the code invalidated balance, unrealizedPnL, activity, and positions queries.
2. Now, positions and activity queries are only invalidated for 'claim' transactions, not for deposit/withdraw.
3. This is a behavioral optimization - deposit/withdraw transactions don't need to refresh positions/activity data.

Tag Selection Rationale:

• SmokePredictions: Primary tag - directly affects Predict transaction handling (deposit, withdraw, claim flows), balance synchronization, and the Positions/Activities tabs.
• SmokeWalletPlatform: Per tag description, "Predictions is also a section inside the Trending tab (SmokeWalletPlatform); changes to Predictions views affect Trending."
• SmokeConfirmations: Per SmokePredictions description, "opening/closing positions are on-chain transactions" that require confirmations. The claim flow involves on-chain transactions.

The change is medium risk because it modifies data refresh behavior that could affect user experience if positions/activity don't update correctly after claim transactions, but it's a targeted optimization that should improve performance by reducing unnecessary query invalidations.

Performance Test Selection:
The change modifies query invalidation logic for Predict transactions, which directly affects how and when data is refreshed in the Predict feature. While this is an optimization (reducing unnecessary invalidations for deposit/withdraw), it's worth running performance tests to verify the change doesn't negatively impact the Predict market loading, position management, or balance display performance. The @PerformancePredict tag covers prediction market list loading, market details, deposit flows, and balance display - all relevant to this change.

View GitHub Actions results

[caieu]

LGTM

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
7 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud