Skip to content

ci: skip smart e2e ai selection for cherry-pick PRs targeting release branch#28331

Merged
chloeYue merged 1 commit into
mainfrom
skip-e2e-selection-release
Apr 3, 2026
Merged

ci: skip smart e2e ai selection for cherry-pick PRs targeting release branch#28331
chloeYue merged 1 commit into
mainfrom
skip-e2e-selection-release

Conversation

@chloeYue
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue commented Apr 2, 2026

Description

This PR is to make release cherry-pick PRs execute the full smoke e2e instead of a reduced tag set chosen by ai.

On main, iterating quickly with a risk-scored subset is a reasonable tradeoff: we accept some residual risk in exchange for speed and we will catch more in follow-up PRs. A PR into release/* is effectively “this build is a candidate to ship.”
Smart selection saves CI time on high-volume main development. Release cherry-picks are low volume and high impact, and we cannot afford to merge cherry-pick that breaks the CI on release branch due to release urgency.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/INFRA-3464

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

cherry-pick PRs should run all e2e tests

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes CI behavior for release-branch PRs by bypassing AI selection and forcing full E2E runs, which can affect build time and which tests execute. Logic is localized to a single composite action and does not touch product code.

Overview
Updates the smart-e2e-selection composite action to detect PRs targeting release/* and skip the AI-based E2E test selection in that case.

For release/* PRs it now forces full E2E execution by setting force_run=true (and ai_confidence=100), and it avoids the checkout/dependency install steps used only for AI analysis; copy updates output/input descriptions to reflect the new behavior.

Written by Cursor Bugbot for commit 122d8e6. This will update automatically on new commits. Configure here.

@chloeYue chloeYue self-assigned this Apr 2, 2026
@chloeYue chloeYue requested a review from a team as a code owner April 2, 2026 10:15
@chloeYue chloeYue marked this pull request as draft April 2, 2026 10:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Apr 2, 2026
@github-actions github-actions Bot added the size-S label Apr 2, 2026
@chloeYue chloeYue changed the title ci: skip ai selection for cherry-pick PRs on release branch ci: skip smart e2e ai selection for cherry-pick PRs targeting release branch Apr 2, 2026
@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeWalletPlatform, SmokeNetworkAbstractions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is .github/actions/smart-e2e-selection/action.yml, which is a CI infrastructure file. The change adds a new code path to handle PRs targeting release/* branches: when detected, AI selection is skipped and force_run=true is set so the full E2E suite runs. This is purely a CI/workflow logic change with no modifications to app code, controllers, UI components, or any user-facing functionality.

What changed:

  1. New step check-release-target detects release/* base branches
  2. All AI analysis steps now skip when targeting a release branch
  3. New elif branch in the analysis script sets FORCE_RUN=true and SHOULD_SKIP=true for release branch PRs
  4. Updated descriptions/comments to reflect new behavior

Impact on app: None — this is purely CI infrastructure.

Why run any tests at all: Since this is a critical CI infrastructure file that controls the test selection pipeline itself, running a representative set of tests validates that the action still works correctly for the normal (non-release-branch) code path. A small but representative set of smoke tests across core areas is appropriate.

Why not run all tags: The app code is completely unchanged. Running all tags would be excessive for a CI description/logic-only change. The selected tags (SmokeAccounts, SmokeConfirmations, SmokeWalletPlatform, SmokeNetworkAbstractions) provide broad coverage across core wallet functionality to validate the pipeline works.

No performance tests needed: No app code, rendering, data loading, or performance-sensitive paths were modified.

Performance Test Selection:
No app code was modified. The change is purely to CI/workflow infrastructure (the smart E2E selection action). No UI components, data loading, state management, or performance-sensitive code paths were touched. Performance tests are not warranted.

View GitHub Actions results

@chloeYue chloeYue removed the team-qa QA team label Apr 2, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.67%. Comparing base (bd7e6fd) to head (122d8e6).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #28331    +/-   ##
========================================
  Coverage   82.66%   82.67%            
========================================
  Files        4866     4869     +3     
  Lines      126134   126239   +105     
  Branches    28268    28293    +25     
========================================
+ Hits       104273   104367    +94     
- Misses      14660    14666     +6     
- Partials     7201     7206     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

@chloeYue chloeYue marked this pull request as ready for review April 3, 2026 14:27
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@chloeYue chloeYue added this pull request to the merge queue Apr 3, 2026
Merged via the queue into main with commit e0e9612 Apr 3, 2026
104 of 109 checks passed
@chloeYue chloeYue deleted the skip-e2e-selection-release branch April 3, 2026 14:53
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-S team-mobile-delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants