fix(ramps): normalize provider IDs in BuildQuote quote matching [TRAM-3331]

[saustrie-consensys]

Description

When selecting a token in the UB2 Buy flow, a quick error ("We've encountered an error") flashes on the amount input screen before the correct "Powered by [provider]" text appears.

The root cause is a provider ID mismatch: the quotes API can return provider IDs in a prefixed format (/providers/transak) while the controller state stores them without the prefix (transak). This caused selectedQuote to resolve to null, briefly rendering the error banner.

The fix normalizes provider IDs on both sides of the comparison using normalizeProviderCode() and switches from array destructuring to .find() so all returned quotes are searched.

Changelog

CHANGELOG entry: Fixed Buy amount screen sometimes showing a generic error when quotes returned for the selected provider but provider id strings differed in format.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-3331
Based on draft PR #27779

Manual testing steps

Feature: Token selection in Buy flow

  Scenario: user selects a token and navigates to amount input
    Given user is on the token selection screen in the Buy flow

    When user selects a token (e.g. ETH)
    Then the amount input screen shows "Powered by [provider]" without any error flash

Screenshots/Recordings

Before

N/A. Reason: This is an extremely rare race condition. It doesn't happen often, and after several changes on main, it's even less common. Nevertheless, we still want to solve this logical condition via this PR.

After

N/A. Reason: This is an extremely rare race condition. It doesn't happen often, and after several changes on main, it's even less common. Nevertheless, we still want to solve this logical condition via this PR.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches Buy flow quote-selection and payment-method loading state; small logic changes but in a user-critical conversion path and could affect when errors/continue button appear.

Overview
Prevents the Buy amount input screen from briefly showing the generic no quotes error by updating BuildQuote to normalize provider IDs (handling /providers/... vs short codes) and to search all returned quotes via .find() when deriving selectedQuote.

Tightens useRampsPaymentMethods loading behavior so isLoading stays true while auto-selecting a payment method when the previously selected method is no longer present, avoiding UI flashes of stale selection. Adds targeted tests covering provider-ID matching scenarios, empty/mismatched quote responses, continue-button disabled state, and the stale-selection loading fallback.

^{Reviewed by Cursor Bugbot for commit 2d4d9d7. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 25ca6bb. Configure here.}

[wachunei]

nit: for clarity

Suggested change

	!paymentMethodsQuery.data.some(
	(m) => m.id === selectedPaymentMethod.id,
	paymentMethodsQuery.data.every(
	(m) => m.id !== selectedPaymentMethod.id,

[saustrie-consensys]

I'll add it now

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeRamps
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are focused entirely within the Ramp (on-ramp/off-ramp) feature:

1. useRampsPaymentMethods.ts: Bug fix for isAutoSelecting logic - now correctly handles the case where a previously selected payment method is no longer in the available list (stale selection). This prevents UI flash during payment method refresh.

2. BuildQuote.tsx: Bug fix for selectedQuote matching - now uses normalizeProviderCode() for provider ID comparison and find() instead of only checking the first quote. This fixes provider ID prefix mismatches (e.g., /providers/moonpay vs moonpay) and cases where the matching quote isn't first in the array.

3. Test files: Unit tests validating the new behaviors.

These are targeted bug fixes in the Ramps feature's BuildQuote flow and payment method selection. The changes are self-contained within app/components/UI/Ramp/ with no impact on shared infrastructure, controllers, navigation, or other wallet features. SmokeRamps is the appropriate and sufficient tag to validate these changes.

Performance Test Selection:
These changes are bug fixes in the Ramps BuildQuote flow and payment method selection logic. They involve minor conditional logic changes (isAutoSelecting check and quote matching via find()) with no impact on rendering performance, data loading patterns, or any performance-sensitive paths. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details