Skip to content

chore: use push EAS directly#28362

Merged
Cal-L merged 4 commits intomainfrom
chore/use-push-eas-directly
Apr 2, 2026
Merged

chore: use push EAS directly#28362
Cal-L merged 4 commits intomainfrom
chore/use-push-eas-directly

Conversation

@weitingsun
Copy link
Copy Markdown
Contributor

@weitingsun weitingsun commented Apr 2, 2026

Description

  • Use push EAS update in the Runway workflow directly
  • Fix PR number null issue

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes the release/OTA GitHub Actions orchestration by switching from API dispatch to a reusable workflow and tweaking PR-number resolution; mistakes here could block OTA publishing or target the wrong ref.

Overview
Updates the OTA publishing pipeline to call push-eas-update.yml as a reusable workflow (workflow_call) instead of dispatching it via actions/github-script, simplifying runway-ota-build-core.yml.

Also fixes PR-number discovery to treat gh pr list returning null as empty (avoiding false positives), and updates CODEOWNERS to include the new build-and-upload-to-testflight.yml workflow under @MetaMask/mobile-admins.

Written by Cursor Bugbot for commit 633c2ac. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested review from a team as code owners April 2, 2026 20:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 2, 2026
@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All three changed files are purely CI/CD infrastructure:

  1. .github/CODEOWNERS: Adds build-and-upload-to-testflight.yml to @MetaMask/mobile-admins ownership. Pure administrative metadata change with zero impact on app code or tests.

  2. .github/workflows/push-eas-update.yml: Adds a workflow_call trigger block to make this workflow reusable by other workflows. No changes to the actual workflow steps or app build logic.

  3. .github/workflows/runway-ota-build-core.yml: Two changes:

    • Bug fix: jq '.[0].number // empty' to normalize null output when PR list is empty (prevents literal "null" string being used as PR number).
    • Refactor: Replaces actions/github-script@v7 + createWorkflowDispatch API call with a direct uses: ./.github/workflows/push-eas-update.yml workflow_call invocation, leveraging the new reusable workflow trigger.

None of these changes touch application source code, test infrastructure (Detox/WDIO), controllers, UI components, navigation, or any code path exercised by E2E tests. These are purely GitHub Actions CI/CD pipeline improvements. No E2E tests need to run to validate these changes.

Performance Test Selection:
No application code was changed. These are purely CI/CD workflow and CODEOWNERS file changes with no impact on app rendering, data loading, state management, or any other performance-sensitive code paths.

View GitHub Actions results

@weitingsun weitingsun self-assigned this Apr 2, 2026
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 69b2afb into main Apr 2, 2026
70 of 76 checks passed
@Cal-L Cal-L deleted the chore/use-push-eas-directly branch April 2, 2026 20:40
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2026
@weitingsun weitingsun added release-7.73.0 Issue or pull request that will be included in release 7.73.0 and removed release-99999.1.0 labels Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-low Low testing needed · Low bug introduction risk size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants