test: add file download E2E tests with local HTML fixtures#28634
Merged
Conversation
Migrate blob and base64 file download tests from quarantined browser-tests.failing.ts. Replace external tyschenko.github.io URLs with local fixtures served by DappServer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
davibroc
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Migrates the two file download E2E tests from the quarantined
browser-tests.failing.tsinto a newbrowser-download.spec.tsfile. Replaces live external URL navigation (tyschenko.github.io) with local HTML fixtures served by DappServer, eliminating external network dependencies and improving test reliability.Part of the effort to increase API mocking coverage for E2E tests (MMQA-1368).
Changelog
CHANGELOG entry: null
Related issues
Fixes: MMQA-1705
Manual testing steps
Screenshots/Recordings
Before
N/A — tests were quarantined in
browser-tests.failing.tsdue to reliance on external URLs.After
Both tests passing locally on iOS simulator:
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk because changes are limited to E2E smoke tests and static HTML/text fixtures, with no production code paths affected.
Overview
Adds a new smoke spec
browser-download.spec.tsthat exercises in-app browser file downloads for both blob and base64 data URL flows.Replaces reliance on external download pages by introducing local DappServer-served fixtures (
tests/fixtures/download/*) that fetch a bundledFile.txtand trigger downloads viaURL.createObjectURLorFileReader.readAsDataURL.Reviewed by Cursor Bugbot for commit 9ca245f. Bugbot is set up for automated code reviews on this repo. Configure here.