Skip to content

feat: migrate ListItem to DSRN usage#28878

Merged
kirillzyusko merged 2 commits into
mainfrom
feat/migrate-list-item
Apr 17, 2026
Merged

feat: migrate ListItem to DSRN usage#28878
kirillzyusko merged 2 commits into
mainfrom
feat/migrate-list-item

Conversation

@kirillzyusko
Copy link
Copy Markdown
Contributor

@kirillzyusko kirillzyusko commented Apr 15, 2026

Description

Migrated ListItem component as part of pilot migration.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-280

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-15.at.19.43.58.mov

After

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-15.at.19.41.54.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only component migration with snapshot updates; main risk is minor layout/spacing/accessibility regressions in the settings drawer rows.

Overview
Migrates SettingsDrawer from legacy list components (ListItemColumn/WidthType) to @metamask/design-system-react-native primitives (ListItem + Box) while preserving the same content structure (title/description/warning and optional arrow).

Updates the DefaultSettings onboarding success Jest snapshot to reflect the new rendered tree/styles from the DSRN components.

Reviewed by Cursor Bugbot for commit 02bc58c. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@kirillzyusko kirillzyusko marked this pull request as ready for review April 16, 2026 14:45
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@kirillzyusko kirillzyusko added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 208c27b Apr 17, 2026
248 of 251 checks passed
@kirillzyusko kirillzyusko deleted the feat/migrate-list-item branch April 17, 2026 13:40
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.75.0 Issue or pull request that will be included in release 7.75.0 size-S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants