feat: migrate ListItem to DSRN usage#28878
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
brianacnguyen
approved these changes
Apr 16, 2026
georgewrmarshall
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Migrated
ListItemcomponent as part of pilot migration.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-280
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-15.at.19.43.58.mov
After
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-15.at.19.41.54.mov
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
UI-only component migration with snapshot updates; main risk is minor layout/spacing/accessibility regressions in the settings drawer rows.
Overview
Migrates
SettingsDrawerfrom legacy list components (ListItemColumn/WidthType) to@metamask/design-system-react-nativeprimitives (ListItem+Box) while preserving the same content structure (title/description/warning and optional arrow).Updates the
DefaultSettingsonboarding success Jest snapshot to reflect the new rendered tree/styles from the DSRN components.Reviewed by Cursor Bugbot for commit 02bc58c. Bugbot is set up for automated code reviews on this repo. Configure here.