You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the margin bottom of advanced chart in token details page to avoid price scale tick being clipped.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Feature: my feature nameScenario: user [verb for user action]Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Low Risk
Pure UI/layout tweak to chart overrides plus formatting-only changes; no business logic, data handling, or security-sensitive code is affected.
Overview
Adjusts TradingView override layout by increasing paneProperties.bottomMargin from 8 to 9 in both the runtime WebView script (chartLogic.js) and its injected string source (chartLogicString.ts) to prevent right price-scale tick labels from being clipped.
Includes a couple of no-op formatting/whitespace-only edits in chartLogicString.ts (line wrapping and blank line normalization).
Reviewed by Cursor Bugbot for commit 588ef84. Bugbot is set up for automated code reviews on this repo. Configure here.
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 95%
click to see 🤖 AI reasoning details
E2E Test Selection:
The changes are extremely minimal and cosmetic:
chartLogic.js: Single-pixel change to paneProperties.bottomMargin from 8 to 9 in the applyChartScaleLayout function. This is a 1px UI tweak to the chart pane bottom margin.
chartLogicString.ts: The same 1px margin change, plus two pure formatting/whitespace changes:
Reformatting a Math.max(0, Math.floor(...)) call to multi-line format (zero logic change)
Removing a trailing whitespace in fetchOlderBars
These changes affect the AdvancedChart WebView component used in token price charts (AssetOverview/Price and TokenDetails). No E2E test tags cover chart rendering pixel-level details. The changes:
Do not affect any wallet flows (accounts, confirmations, swaps, networks)
Do not affect any navigation or shared components
Are purely cosmetic (1px margin + code formatting)
Cannot break any existing E2E test assertions
No E2E test tags are warranted for these trivial cosmetic changes.
Performance Test Selection:
The changes are a 1px bottom margin adjustment and code formatting cleanup in the AdvancedChart WebView. This does not affect rendering performance, data loading, state management, or any measurable performance metric. No performance tests are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the margin bottom of advanced chart in token details page to avoid price scale tick being clipped.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Pure UI/layout tweak to chart overrides plus formatting-only changes; no business logic, data handling, or security-sensitive code is affected.
Overview
Adjusts TradingView override layout by increasing
paneProperties.bottomMarginfrom8to9in both the runtime WebView script (chartLogic.js) and its injected string source (chartLogicString.ts) to prevent right price-scale tick labels from being clipped.Includes a couple of no-op formatting/whitespace-only edits in
chartLogicString.ts(line wrapping and blank line normalization).Reviewed by Cursor Bugbot for commit 588ef84. Bugbot is set up for automated code reviews on this repo. Configure here.