Skip to content

chore: bump chart margin on token details cp-7.74.0#28958

Merged
sahar-fehri merged 1 commit into
mainfrom
fix/bump-margin-on-token-details-chart
Apr 17, 2026
Merged

chore: bump chart margin on token details cp-7.74.0#28958
sahar-fehri merged 1 commit into
mainfrom
fix/bump-margin-on-token-details-chart

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented Apr 16, 2026

Description

Updates the margin bottom of advanced chart in token details page to avoid price scale tick being clipped.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Screenshot 2026-04-17 at 01 58 23

After

Screenshot 2026-04-17 at 01 58 35

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Pure UI/layout tweak to chart overrides plus formatting-only changes; no business logic, data handling, or security-sensitive code is affected.

Overview
Adjusts TradingView override layout by increasing paneProperties.bottomMargin from 8 to 9 in both the runtime WebView script (chartLogic.js) and its injected string source (chartLogicString.ts) to prevent right price-scale tick labels from being clipped.

Includes a couple of no-op formatting/whitespace-only edits in chartLogicString.ts (line wrapping and blank line normalization).

Reviewed by Cursor Bugbot for commit 588ef84. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are extremely minimal and cosmetic:

  1. chartLogic.js: Single-pixel change to paneProperties.bottomMargin from 8 to 9 in the applyChartScaleLayout function. This is a 1px UI tweak to the chart pane bottom margin.

  2. chartLogicString.ts: The same 1px margin change, plus two pure formatting/whitespace changes:

    • Reformatting a Math.max(0, Math.floor(...)) call to multi-line format (zero logic change)
    • Removing a trailing whitespace in fetchOlderBars

These changes affect the AdvancedChart WebView component used in token price charts (AssetOverview/Price and TokenDetails). No E2E test tags cover chart rendering pixel-level details. The changes:

  • Do not affect any wallet flows (accounts, confirmations, swaps, networks)
  • Do not affect any navigation or shared components
  • Are purely cosmetic (1px margin + code formatting)
  • Cannot break any existing E2E test assertions

No E2E test tags are warranted for these trivial cosmetic changes.

Performance Test Selection:
The changes are a 1px bottom margin adjustment and code formatting cleanup in the AdvancedChart WebView. This does not affect rendering performance, data loading, state management, or any measurable performance metric. No performance tests are needed.

View GitHub Actions results

@sahar-fehri sahar-fehri changed the title chore: bump chart margin on token details chore: bump chart margin on token details cp-7.74.0 Apr 17, 2026
@sonarqubecloud
Copy link
Copy Markdown

@sahar-fehri sahar-fehri enabled auto-merge April 17, 2026 00:20
@sahar-fehri sahar-fehri added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit a69be23 Apr 17, 2026
87 of 92 checks passed
@sahar-fehri sahar-fehri deleted the fix/bump-margin-on-token-details-chart branch April 17, 2026 00:33
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.75.0 Issue or pull request that will be included in release 7.75.0 risk-low Low testing needed · Low bug introduction risk size-S team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants