You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR to use DS icons instead of custom SVG icons for chart.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Feature: my feature nameScenario: user [verb for user action]Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Low Risk
Low risk UI-only change that swaps the chart type toggle’s custom SVG icons for design-system Icon components; behavior and data flow are unchanged.
Overview
Updates the token details chart TimeRangeSelector to remove custom react-native-svg candlestick/line icons and instead render the design-system Icon (IconName.TrendUp / IconName.Candlestick) for the chart type toggle.
This simplifies icon rendering by relying on DS-provided sizing/color tokens (IconSize, IconColor) rather than inline SVG paths.
Reviewed by Cursor Bugbot for commit a710363. Bugbot is set up for automated code reviews on this repo. Configure here.
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 92%
click to see 🤖 AI reasoning details
E2E Test Selection:
The change in TimeRangeSelector.tsx is a pure UI refactor: it removes two custom inline SVG icon components (CandlestickIcon and LineChartIcon built with react-native-svg) and replaces them with standard Icon components from @metamask/design-system-react-native. The IconSize import is also consolidated to come from the design system package instead of the local component library. There are no logic, state, API, or behavioral changes. The component is used in the AdvancedChart within the AssetOverview price view (token detail screen). No E2E tests directly cover the chart type toggle button functionality, and this change does not affect any critical user flows (accounts, confirmations, swaps, networks, etc.). The risk is low and no E2E test tags are warranted.
Performance Test Selection:
This is a pure icon rendering refactor — replacing custom SVG components with design system Icon components. If anything, this slightly simplifies rendering (fewer custom SVG nodes). No performance impact is expected, and no performance test tags are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR to use DS icons instead of custom SVG icons for chart.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2026-04-23.at.22.15.16.mov
After
Screen.Recording.2026-04-23.at.22.14.29.mov
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only change that swaps the chart type toggle’s custom SVG icons for design-system
Iconcomponents; behavior and data flow are unchanged.Overview
Updates the token details chart
TimeRangeSelectorto remove customreact-native-svgcandlestick/line icons and instead render the design-systemIcon(IconName.TrendUp/IconName.Candlestick) for the chart type toggle.This simplifies icon rendering by relying on DS-provided sizing/color tokens (
IconSize,IconColor) rather than inline SVG paths.Reviewed by Cursor Bugbot for commit a710363. Bugbot is set up for automated code reviews on this repo. Configure here.