chore: update @metamask/transaction-pay-controller by jpuri · Pull Request #29302 · MetaMask/metamask-mobile

jpuri · 2026-04-24T04:17:17Z

Description

Update @metamask/transaction-pay-controller, to add change to accountOverride property.

Changelog

CHANGELOG entry:

Related issues

Ref: https://consensyssoftware.atlassian.net/browse/CONF-1187

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Dependency bumps pull in newer @metamask/* controller and keyring packages, which can subtly change transaction/payment and bridge behavior at runtime. App code changes are minimal, but lockfile/resolution shifts increase integration/regression risk.

Overview
Upgrades @metamask/transaction-pay-controller to ^19.3.0 and updates the lockfile/resolutions to align on newer @metamask/* packages (notably @metamask/keyring-api 23.0.1, plus related bridge/assets/keyring client/internal deps).

Updates accountsControllerTestUtils.ts to recognize Stellar (XlmAccountType.Account -> XlmScope.Pubnet) when generating mock account scopes.

^{Reviewed by Cursor Bugbot for commit e677792. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-04-24T04:17:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2026-04-24T04:17:41Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
npm/@metamask/assets-controller@6.0.0 ⏵ 6.1.0		⁺¹	⁺¹
npm/@metamask/assets-controllers@104.2.0 ⏵ 104.3.0	^-25	⁺¹
npm/@metamask/keyring-internal-api@10.0.1 ⏵ 10.1.1	⁺¹	⁺¹	⁺²
npm/@metamask/bridge-controller@70.1.1 ⏵ 70.2.0	⁺¹	⁺¹
npm/@metamask/transaction-pay-controller@19.2.2 ⏵ 19.3.0	⁺¹	⁺¹	⁺¹
npm/@metamask/account-api@1.0.0 ⏵ 1.0.3	⁺¹	⁺²⁵	⁺⁸

View full report

socket-security · 2026-04-24T04:17:43Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

npm/@metamask/assets-controllers@104.3.0

View full report

jpuri · 2026-04-24T04:18:21Z

@SocketSecurity ignore npm/@metamask/assets-controllers@104.3.0

ccharly · 2026-04-24T07:53:08Z

+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    }) as MultichainAccountWallet<any>;


I think we could use a resolution to align the keyring-api version for all controllers (until we update all other deps) so we avoid doing this kind of type-cast.

Let me try that locally

Indeed, could you instead use resolution:

diff --git a/package.json b/package.json index 180a943a47..a40b116569 100644 --- a/package.json +++ b/package.json @@ -204,7 +204,8 @@ "@metamask/messenger@^0.3.0": "^1.0.0", "@metamask/accounts-controller": "^37.2.0", "@metamask/profile-sync-controller": "^28.0.2", - "@metamask/transaction-controller@^63.0.0": "^64.2.0" + "@metamask/transaction-controller@^63.0.0": "^64.2.0", + "@metamask/keyring-api": "^23.0.1" }, "dependencies": { "@braze/react-native-sdk": "patch:@braze/react-native-sdk@npm%3A19.1.0#~/.yarn/patches/@braze-react-native-sdk-npm-19.1.0-076-reactmoduleinfo.patch",

We're currently working on updating all clients to update all accounts deps, so we'll remove the resolutions once everything has been updated.

Good point, I updated the PR.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9704c3e. Configure here.}

github-actions · 2026-04-24T09:11:25Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, FlaskBuildTests
Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
Risk Level: high
AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/transaction-controller@^63.0.0, @metamask/transaction-pay-controller. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/transaction-controller@^63.0.0, @metamask/transaction-pay-controller. Running all tests.

View GitHub Actions results

sonarqubecloud · 2026-04-24T09:32:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-24T09:43:14Z

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

ccharly

LGTM for accounts (not tested)

ccharly · 2026-04-24T10:43:10Z

+    "@metamask/keyring-api@npm:^21.3.0": "21.6.0",
+    "@metamask/keyring-api@npm:^21.4.0": "21.6.0",
+    "@metamask/keyring-api@npm:^21.5.0": "21.6.0",
+    "@metamask/keyring-api@npm:^21.6.0": "23.0.1",
+    "@metamask/keyring-api@npm:^22.0.0": "23.0.1",
+    "@metamask/keyring-api@npm:^23.0.1": "23.0.1"


For tracking purposes: This is expected and we're going to re-align all accounts deps very soon!

chore: update @metamask/transaction-pay-controller

f360ae8

jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Apr 24, 2026

jpuri enabled auto-merge April 24, 2026 04:18

github-actions Bot added the size-XS label Apr 24, 2026

update

7ec7a85

cursor Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread package.json

update

2673ded

github-actions Bot added size-S and removed size-XS labels Apr 24, 2026

update

e557fd9

jpuri requested a review from a team as a code owner April 24, 2026 04:50

jpuri commented Apr 24, 2026

View reviewed changes

Comment thread package.json Outdated

jpuri commented Apr 24, 2026

View reviewed changes

Comment thread package.json Outdated

ccharly reviewed Apr 24, 2026

View reviewed changes

update

9704c3e

jpuri requested a review from ccharly April 24, 2026 09:00

cursor Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread package.json Outdated

jpuri added 2 commits April 24, 2026 14:38

update

bad65b3

Merge branch 'main' into pay_ctrl_update

e677792

ccharly approved these changes Apr 24, 2026

View reviewed changes

jpuri added this pull request to the merge queue Apr 24, 2026

Merged via the queue into main with commit 73a4e87 Apr 24, 2026
116 checks passed

jpuri deleted the pay_ctrl_update branch April 24, 2026 10:58

github-actions Bot locked and limited conversation to collaborators Apr 24, 2026

metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 24, 2026

		// eslint-disable-next-line @typescript-eslint/no-explicit-any
		}) as MultichainAccountWallet<any>;

Uh oh!

Conversation

jpuri commented Apr 24, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

socket-security Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpuri commented Apr 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccharly Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

ccharly Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

jpuri Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Apr 24, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

ccharly Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpuri commented Apr 24, 2026 •

edited by cursor Bot

Loading

socket-security Bot commented Apr 24, 2026 •

edited

Loading

socket-security Bot commented Apr 24, 2026 •

edited

Loading