Skip to content

test: upload Test Plan JSON file to artifacts#29337

Merged
sleepytanya merged 1 commit into
mainfrom
fix/test-plan-artifact-upload
Apr 24, 2026
Merged

test: upload Test Plan JSON file to artifacts#29337
sleepytanya merged 1 commit into
mainfrom
fix/test-plan-artifact-upload

Conversation

@sleepytanya
Copy link
Copy Markdown
Contributor

@sleepytanya sleepytanya commented Apr 24, 2026

Description

Fix broken Test Plan JSON link by uploading as GitHub Actions artifact instead of gh-pages (which is blocked by branch protection).

Changes

  • Replace gh-pages upload with actions/upload-artifact@v4 (unzipped)
  • Update PR comment to link to build workflow for artifact access

Changelog

CHANGELOG entry: null

Related issues

Fixes:
https://consensyssoftware.atlassian.net/browse/MCRM-69

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya requested a review from a team as a code owner April 24, 2026 15:17
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label Apr 24, 2026
@sleepytanya sleepytanya changed the title Upload Test Plan JSON file to artifacts test: upload Test Plan JSON file to artifacts Apr 24, 2026
@sleepytanya sleepytanya added No QA Needed Apply this label when your PR does not need any QA effort. release-7.75.0 Issue or pull request that will be included in release 7.75.0 labels Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files are purely CI/CD infrastructure changes with no impact on app code or E2E test flows:

  1. .github/workflows/build-rc-auto.yml: Replaces a complex git-based upload to a gh-pages branch with a simpler actions/upload-artifact@v4 action. This is a workflow simplification — the test plan JSON is now stored as a GitHub Actions artifact instead of being committed to a gh-pages branch. No app code, test logic, or user flows are affected.

  2. scripts/build-announce/test-plan-section.ts: Updates the markdown text in the build announcement to reference the new artifact location instead of a GitHub Pages URL. This is a string/URL change in a build script, not in any app code.

Neither change touches:

  • Any app source code or components
  • Any E2E test files or test infrastructure
  • Any controllers, Engine, or core modules
  • Any UI components or user flows
  • Any performance-sensitive code paths

These are low-risk CI/CD housekeeping changes. No E2E tests are needed to validate them — the changes only affect how the RC build workflow stores and references the test plan artifact.

Performance Test Selection:
The changes are purely CI/CD infrastructure changes affecting how the test plan JSON artifact is stored and referenced. No app code, rendering, data loading, or performance-sensitive paths are touched. Performance tests are not warranted.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@sleepytanya sleepytanya enabled auto-merge April 24, 2026 15:52
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleepytanya sleepytanya added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit e741248 Apr 24, 2026
101 of 105 checks passed
@sleepytanya sleepytanya deleted the fix/test-plan-artifact-upload branch April 24, 2026 16:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.75.0 Issue or pull request that will be included in release 7.75.0 release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants