fix(confirmations): prevent Perps withdraw clipping on Android cp-7.75.0#29434
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7283c20 to
bc088df
Compare
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
d509575 to
6f900f2
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f900f2. Configure here.
Bugbot flagged that the new hasExtraBottomPadding tests asserted only that the keyboard rendered, identical to existing coverage. Add a testID on the bottom block, mock Platform.OS, and assert the actual paddingBottom value is applied on Android, omitted on iOS, and gated by the prop.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
This is a targeted Android layout fix for the Perps Withdraw screen, preventing the UI from clipping behind the system gesture bar. The change is backward-compatible (optional prop, no logic changes). SmokePerps: Directly validates the Perps Withdraw flow where the fix is applied. No other flows are affected since Performance Test Selection: |
|
|
✅ E2E Fixture Validation — Schema is up to date |




Description
Fixes an Android layout issue where the Perps Withdraw confirmation keypad bottom row and the final Withdraw button could be clipped behind the system navigation area.
The fix keeps the shared full-screen confirmation layout intact, ensures the confirmation ScrollView fills its safe-area container, and applies extra Android bottom spacing only to the Perps Withdraw bottom block.
Changelog
CHANGELOG entry: Fixed Perps Withdraw on Android so the keypad and Withdraw button remain fully visible.
Related issues
Fixes: #29363
Manual testing steps
Screenshots/Recordings
Before
Android Perps Withdraw keypad / Withdraw button clipped behind the system navigation area.
After
Android Perps Withdraw keypad and Withdraw button fully visible. Verified on Pixel 6 and Pixel 10 Pro XL.
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Small, opt-in styling change scoped to Perps Withdraw (and Android-only) with added unit tests; minimal risk beyond potential minor layout spacing differences on affected screens.
Overview
Prevents Perps Withdraw confirmation UI from clipping behind the Android gesture/navigation bar by adding an opt-in
hasExtraBottomPaddingprop toCustomAmountInfoand applying a 56dppaddingBottomto the bottom block only on Android.PerpsWithdrawInfonow enables this padding, and new test IDs plus unit tests cover the platform-conditional styling and prop behavior to avoid iOS/layout regressions.Reviewed by Cursor Bugbot for commit dd5c508. Bugbot is set up for automated code reviews on this repo. Configure here.