Skip to content

Conversation

@elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Jul 24, 2025

Explanation

We remove onAnalytics event listener in the new modal abstraction as it is no longer needed. Whichever package can directly use the globally Analytics instance by just importing the package and it will just work.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@elribonazo elribonazo requested a review from a team as a code owner July 24, 2025 11:52
@elribonazo elribonazo linked an issue Jul 24, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.93%. Comparing base (38271d2) to head (2a4bf50).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         184      184           
  Lines        4513     4513           
  Branches     1105     1105           
=======================================
  Hits         3382     3382           
  Misses       1131     1131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@elribonazo elribonazo enabled auto-merge (squash) July 24, 2025 12:21
@elribonazo elribonazo merged commit 84ebd18 into main Jul 24, 2025
40 checks passed
@elribonazo elribonazo deleted the 1328-remove-old-analytics-event-listeners-on-ui-modal-abstraction branch July 24, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old analytics event listeners on UI Modal abstraction

3 participants