Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Remove iFrame logic along with publicConfig #41

Merged
rekmarks merged 2 commits into from
Nov 30, 2020
Merged

Remove iFrame logic along with publicConfig #41

rekmarks merged 2 commits into from
Nov 30, 2020

Conversation

@andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Nov 12, 2020

This PR removes iFrame logic along with publicConfig.

@andrepimenta andrepimenta requested a review from a team as a code owner November 12, 2020 12:19
rekmarks
rekmarks suggested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you search all files for publicConfig, there's more code to remove in setProvider.js and inpage/index.js.

@rekmarks
Copy link
Member

rekmarks commented Nov 28, 2020 •
edited
Loading

Don't bother with setProvider.js, which is removed entirely in #42.

@rekmarks
Copy link
Member

rekmarks commented Nov 28, 2020

The only remaining publicConfigStore reference we care about is in inpage/index.js.

@andrepimenta
Copy link
Member Author

andrepimenta commented Nov 30, 2020

The only remaining publicConfigStore reference we care about is in inpage/index.js.

Should be good now!

@rekmarks rekmarks merged commit 9584d76 into master Nov 30, 2020
@rekmarks rekmarks deleted the remove-iframe-logic-and-public-config branch November 30, 2020 18:11
@rekmarks rekmarks mentioned this pull request Jan 20, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rekmarks rekmarks rekmarks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrepimenta @rekmarks