-
-
Notifications
You must be signed in to change notification settings - Fork 41
Bump @metamask/inpage-providers to @metamask/providers
#85
Conversation
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @metamask/inpage-provider@8.0.3 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
jiexi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. i'll look into the failed CI pipeline
| "webpack-cli": "^3.3.10" | ||
| }, | ||
| "resolutions": { | ||
| "stream-browserify": "^3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed for stream.pipeline since webpack v4 uses v2 still. Another reason for us to get up to date with webpack
|
|
Just to be clear, this is meant to indicate that when pulled into a local mobile build the changes are indeed present and working, correct @jiexi ? |
|
@adonesky1 Yes, exactly that. See the deprecation warnings for accessing |
|
@SocketSecurity ignore extension-port-stream@2.1.1 |
|
@SocketSecurity ignore unicode-canonical-property-names-ecmascript@2.0.0 Google's npm bot |
|
@SocketSecurity ignore update-browserslist-db@1.0.13 wrappers around specific commands to npx |
|
@SocketSecurity ignore @babel/plugin-syntax-import-meta@7.10.4 unmaintained |
|
@SocketSecurity ignore convert-source-map@2.0.0 author has been around 3 years ago |
sethkfman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Successfully building, node version at 16.
Node v18 introduces new errors that will likely require webpack version bump to v5 which is trickier