Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Conversation

@adonesky1
Copy link
Contributor

Successfully building, node version at 16.

Node v18 introduces new errors that will likely require webpack version bump to v5 which is trickier

@socket-security
Copy link

socket-security bot commented Sep 29, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@babel/plugin-proposal-nullish-coalescing-operator 7.18.6 shell +33 10.4 MB nicolo-ribaudo
@metamask/providers 13.0.0 None +10 730 kB metamaskbot
@babel/preset-env 7.12.7...7.22.20 shell +108/-109 12.5 MB nicolo-ribaudo
@babel/core 7.7.2...7.23.0 shell, environment +31/-11 10.4 MB nicolo-ribaudo

🚮 Removed packages: @metamask/inpage-provider@8.0.3

@socket-security
Copy link

socket-security bot commented Sep 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @babel/plugin-syntax-import-meta@7.10.4, extension-port-stream@2.1.1, @metamask/safe-event-emitter@3.0.0, convert-source-map@2.0.0, unicode-canonical-property-names-ecmascript@2.0.0, unicode-match-property-ecmascript@2.0.0, update-browserslist-db@1.0.13

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

jiexi
jiexi previously approved these changes Sep 29, 2023
Copy link
Contributor

@jiexi jiexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. i'll look into the failed CI pipeline

@adonesky1 adonesky1 marked this pull request as ready for review September 29, 2023 17:12
@adonesky1 adonesky1 requested a review from rekmarks as a code owner September 29, 2023 17:12
"webpack-cli": "^3.3.10"
},
"resolutions": {
"stream-browserify": "^3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for stream.pipeline since webpack v4 uses v2 still. Another reason for us to get up to date with webpack

@jiexi
Copy link
Contributor

jiexi commented Sep 29, 2023

Screenshot 2023-09-29 at 10 54 43 AM

@jiexi
Copy link
Contributor

jiexi commented Sep 29, 2023

@metamask/providers changelog

  • v8: We are here
  • v9: No action required
  • v10: I don't see METAMASK_EXTENSION_STREAM_CONNECT used anywhere anymore in extension. All i see is this in regards to retry. Searching the whole org yields nothing much
  • v11: Node16. Fixed
  • v12: Causes more version misalignment on upstream deps. Mobile is currently not aligned on these deps, so we make this no worse
  • v13: No action required

@adonesky1
Copy link
Contributor Author

#85 (comment)

Just to be clear, this is meant to indicate that when pulled into a local mobile build the changes are indeed present and working, correct @jiexi ?

@jiexi
Copy link
Contributor

jiexi commented Sep 29, 2023

@adonesky1 Yes, exactly that. See the deprecation warnings for accessing window.ethereum.chainId and others which is part of the v13 release

@jiexi
Copy link
Contributor

jiexi commented Sep 29, 2023

@SocketSecurity ignore extension-port-stream@2.1.1
@SocketSecurity ignore @metamask/safe-event-emitter@3.0.0

@jiexi
Copy link
Contributor

jiexi commented Oct 2, 2023

@SocketSecurity ignore unicode-canonical-property-names-ecmascript@2.0.0
@SocketSecurity ignore unicode-match-property-ecmascript@2.0.0

Google's npm bot

@jiexi
Copy link
Contributor

jiexi commented Oct 2, 2023

@SocketSecurity ignore update-browserslist-db@1.0.13

wrappers around specific commands to npx

@jiexi
Copy link
Contributor

jiexi commented Oct 2, 2023

@SocketSecurity ignore @babel/plugin-syntax-import-meta@7.10.4

unmaintained

@jiexi
Copy link
Contributor

jiexi commented Oct 2, 2023

@SocketSecurity ignore convert-source-map@2.0.0

author has been around 3 years ago

@jiexi jiexi requested a review from andrepimenta October 2, 2023 22:40
Copy link

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 merged commit aa92cb9 into main Oct 5, 2023
@adonesky1 adonesky1 deleted the bump-providers branch October 5, 2023 16:17
@adonesky1 adonesky1 mentioned this pull request Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants