fix: enhance MetaMask extension ID detection with retry logic #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
reviewed
Jul 30, 2025
| window.removeEventListener('message', messageHandler); | ||
| reject(new Error('MetaMask extension not found')); | ||
| }, 3000); | ||
| }, 10000); |
Contributor
There was a problem hiding this comment.
my slight gripe with this approach is that even if we get a response from metamask_getProviderState before 10s, if it doesn't have extensionId we won't return an error until the 10s timeout has been reached.
I'm not sure if that is a big deal though, but this is why I think putting an id in the metamask_getProviderState so that we can identify the response is important
jiexi
approved these changes
Jul 31, 2025
EdouardBougon
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.