feat(ocap-kernel): Prevent overriding endowment names

[grypez]

This PR ensures that the various sources of vat namespace endowments do not provide colliding names, causing the VatSupervisor to throw an error instead in this case.

[sirtimid]

Suggested change

	for (const obj of objects) {
	for (const key of Reflect.ownKeys(obj)) {
	if (keys.has(key)) {
	const originalIndex = keys.get(key);
	objects.forEach((obj, originalIndex) => {
	for (const key of Reflect.ownKeys(obj)) {
	if (keys.has(key)) {

I guess this is simpler?

[sirtimid]

Ah no you are using the collidingIndex. But I'm not so sure why we need that and not simply do something like

  const seen = new Map<PropertyKey, number>();
  const out: Record<PropertyKey, unknown> = Object.create(null);

  objects.forEach((obj, idx) => {
    for (const key of Reflect.ownKeys(obj)) {
      if (seen.has(key)) {
        throw new Error(
          `Duplicate key "${String(key)}" found in entries ${seen.get(key)} and ${idx}`
        );
      }
      seen.set(key, idx);
    }
    Object.defineProperties(out, Object.getOwnPropertyDescriptors(obj));
  });

  return out 

[grypez]

In this case the index is used to differentiate between an internal error and a user error where the VatSupervisor uses the function.

[cursor]

Bug: Endowment Collision Classification Error

The DuplicateEndowmentError.isInternal flag is incorrectly determined. It currently only checks if collidingIndex === 1, which misclassifies internal endowment collisions. Since workerEndowments, platformEndowments, and lsEndowments are all internal sources, any collision between them should be marked as internal. The classification needs to consider both originalIndex and collidingIndex to accurately reflect internal conflicts.

 

[sirtimid]

LGTM