-
Notifications
You must be signed in to change notification settings - Fork 5
fix: Simplify Dependabot config to fix Yarn 4 workspace incompatibility #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The grouped dependency updates were causing Dependabot to fail with: - "peer dependencies are incorrectly met" errors - "Couldn't find the node_modules state file" errors This commit removes all dependency groups and switches to a simpler configuration pattern that is proven to work with Yarn 4 workspaces, based on the working configuration in MetaMask/core. Changes: - Remove all 10 dependency groups (vite, metamask, react, etc.) - Add 'allow' lists for high-priority packages (@metamask/*, @agoric/*, @endo/*) - Add github-actions ecosystem monitoring - Keep weekly schedule and other working settings Trade-off: Will receive more individual PRs instead of grouped ones, but Dependabot will actually work and be able to update dependencies. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
9caa57e to
285b8e4
Compare
| allow: | ||
| - dependency-name: '@metamask/*' | ||
| - dependency-name: '@agoric/*' | ||
| - dependency-name: '@endo/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package ses excluded from new allow list
Medium Severity
The ses package was explicitly included in the original agoric group alongside @agoric/* and @endo/*, but it's missing from the new allow list. Since ses is a standalone package without a namespace prefix, it won't match @agoric/* or @endo/* patterns. This means the ses package will no longer receive version updates, even though it's part of the same ecosystem the configuration intends to monitor.
grypez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proven to work in MetaMask/core SGTM
|
Wondering if cursor bot may have been onto something there... |
|
Ah, shoot, yes it was. Will fix. |
Restores `ses` as an allowed dependency to update in the Dependabot config after it was accidentally removed in #729.
Restores `ses` as an allowed dependency to update in the Dependabot config after it was accidentally removed in #729. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Restores Dependabot updates for the `ses` package. > > - Adds `ses` to the `allow` list in `.github/dependabot.yml` under the npm ecosystem > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0145bb7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
The grouped dependency updates were causing Dependabot to fail with:
This commit removes all dependency groups and switches to a simpler configuration pattern that is proven to work with Yarn 4 workspaces, based on the working configuration in
MetaMask/core.Changes:
Trade-off: Will receive more individual PRs instead of grouped ones, but Dependabot will (hopefully) actually work and be able to update dependencies.
Note
Dependabot config simplified for Yarn 4 workspaces
groupsand thetarget-branchsetting from.github/dependabot.ymlallowlist for@metamask/*,@agoric/*, and@endo/*github-actionsecosystem with a weekly scheduleincrease-if-necessaryversioning, and PR limitsWritten by Cursor Bugbot for commit c008365. This will update automatically on new commits. Configure here.