Skip to content

chore(deps): Update MetaMask design system and React to v18#746

Merged
sirtimid merged 3 commits intomainfrom
sirtimid/update-design-system-react-18
Jan 20, 2026
Merged

chore(deps): Update MetaMask design system and React to v18#746
sirtimid merged 3 commits intomainfrom
sirtimid/update-design-system-react-18

Conversation

@sirtimid
Copy link
Copy Markdown
Contributor

@sirtimid sirtimid commented Jan 13, 2026

Summary

  • Update @metamask/design-system-react from ^0.1.0 to ^0.6.0
  • Update @metamask/design-system-tailwind-preset from ^0.5.0 to ^0.6.1
  • Update @metamask/design-tokens from ^8.0.0 to ^8.1.1
  • Update react and react-dom from ^17.0.2 to ^18.3.1
  • Update @types/react and @types/react-dom to v18
  • Update @testing-library/react from ^12.1.5 to ^16.3.0 (removes need for separate @testing-library/react-hooks)
  • Update @radix-ui/react-slot to 1.2.4 (removes the yarn patch)

Code changes for React 18 compatibility

  • Use createRoot API instead of deprecated render in popup entry points
  • Explicitly type children prop in TableHeader component (React 18 no longer includes children implicitly in React.FC)
  • Update test imports from @testing-library/react-hooks to @testing-library/react
  • Update Vite config for React externals (function-based approach)

Test plan

  • yarn build passes
  • yarn test passes (3338 tests)
  • yarn test:e2e:ci passes (45 e2e tests across extension, nodejs, omnium-gatherum)

🤖 Generated with Claude Code


Note

Upgrades React and the MetaMask design system, with minimal code and test changes for compatibility.

  • Upgrade react/react-dom (and types) to v18 across packages; migrate popup entry points to createRoot
  • Bump @metamask/design-system-react to ^0.6.0 (and related preset/tokens); update TableHeader to explicitly accept children
  • Replace @testing-library/react-hooks with @testing-library/react; update tests and add Vitest aliases for react/jsx-runtime(.js) and deps optimizer includes
  • Update kernel-ui Vite config to function-based externals for React subpaths
  • Dependency housekeeping: remove Yarn patch by bumping @radix-ui/react-slot to 1.2.4; lockfile and coverage thresholds refreshed

Written by Cursor Bugbot for commit 1f8f1e4. This will update automatically on new commits. Configure here.

@sirtimid sirtimid requested a review from a team as a code owner January 13, 2026 20:11
@sirtimid sirtimid force-pushed the sirtimid/update-design-system-react-18 branch from a9412a2 to 5873a04 Compare January 13, 2026 20:12
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 13, 2026

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 13, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • @metamask/design-system-shared@0.1.1
  • scheduler@0.23.2
  • react-dom@18.3.1
  • react@18.3.1
  • @types/react-dom@18.3.7
  • @metamask/design-tokens@8.1.1
  • @metamask/design-system-tailwind-preset@0.6.1
  • csstype@3.2.3
  • @types/react@18.3.27
  • @metamask/design-system-react@0.6.0
  • @testing-library/react@16.3.1

View full report

@sirtimid
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore-all

@sirtimid sirtimid enabled auto-merge (squash) January 13, 2026 20:20
@sirtimid sirtimid force-pushed the sirtimid/update-design-system-react-18 branch 2 times, most recently from 78a3620 to 79eb856 Compare January 14, 2026 17:27
rekmarks
rekmarks previously approved these changes Jan 20, 2026
sirtimid and others added 3 commits January 21, 2026 00:44
- Update @metamask/design-system-react: ^0.1.0 → ^0.6.0
- Update @metamask/design-system-tailwind-preset: ^0.5.0 → ^0.6.1
- Update @metamask/design-tokens: ^8.0.0 → ^8.1.1
- Update react and react-dom: ^17.0.2 → ^18.3.1
- Update @types/react and @types/react-dom to v18
- Update @testing-library/react: ^12.1.5 → ^16.3.0
- Update @radix-ui/react-slot: 1.2.3 → 1.2.4 (removes patch)

Code changes for React 18 compatibility:
- Use createRoot API instead of deprecated render
- Explicitly type children prop in TableHeader (React 18 change)
- Update test imports from @testing-library/react-hooks to @testing-library/react
- Update Vite config for React externals

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sirtimid sirtimid force-pushed the sirtimid/update-design-system-react-18 branch from 79eb856 to 1f8f1e4 Compare January 20, 2026 22:51
@sirtimid sirtimid requested a review from rekmarks January 20, 2026 22:51
@sirtimid sirtimid added this pull request to the merge queue Jan 20, 2026
Merged via the queue into main with commit 257a35e Jan 20, 2026
28 checks passed
@sirtimid sirtimid deleted the sirtimid/update-design-system-react-18 branch January 20, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants