chore(deps): Update MetaMask design system and React to v18#746
Merged
chore(deps): Update MetaMask design system and React to v18#746
Conversation
a9412a2 to
5873a04
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore-all |
78a3620 to
79eb856
Compare
rekmarks
previously approved these changes
Jan 20, 2026
- Update @metamask/design-system-react: ^0.1.0 → ^0.6.0 - Update @metamask/design-system-tailwind-preset: ^0.5.0 → ^0.6.1 - Update @metamask/design-tokens: ^8.0.0 → ^8.1.1 - Update react and react-dom: ^17.0.2 → ^18.3.1 - Update @types/react and @types/react-dom to v18 - Update @testing-library/react: ^12.1.5 → ^16.3.0 - Update @radix-ui/react-slot: 1.2.3 → 1.2.4 (removes patch) Code changes for React 18 compatibility: - Use createRoot API instead of deprecated render - Explicitly type children prop in TableHeader (React 18 change) - Update test imports from @testing-library/react-hooks to @testing-library/react - Update Vite config for React externals Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
79eb856 to
1f8f1e4
Compare
rekmarks
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/design-system-reactfrom ^0.1.0 to ^0.6.0@metamask/design-system-tailwind-presetfrom ^0.5.0 to ^0.6.1@metamask/design-tokensfrom ^8.0.0 to ^8.1.1reactandreact-domfrom ^17.0.2 to ^18.3.1@types/reactand@types/react-domto v18@testing-library/reactfrom ^12.1.5 to ^16.3.0 (removes need for separate@testing-library/react-hooks)@radix-ui/react-slotto 1.2.4 (removes the yarn patch)Code changes for React 18 compatibility
createRootAPI instead of deprecatedrenderin popup entry pointschildrenprop inTableHeadercomponent (React 18 no longer includes children implicitly inReact.FC)@testing-library/react-hooksto@testing-library/reactTest plan
yarn buildpassesyarn testpasses (3338 tests)yarn test:e2e:cipasses (45 e2e tests across extension, nodejs, omnium-gatherum)🤖 Generated with Claude Code
Note
Upgrades React and the MetaMask design system, with minimal code and test changes for compatibility.
react/react-dom(and types) to v18 across packages; migrate popup entry points tocreateRoot@metamask/design-system-reactto^0.6.0(and related preset/tokens); updateTableHeaderto explicitly acceptchildren@testing-library/react-hookswith@testing-library/react; update tests and add Vitest aliases forreact/jsx-runtime(.js)and deps optimizer includeskernel-uiVite config to function-based externals for React subpaths@radix-ui/react-slotto1.2.4; lockfile and coverage thresholds refreshedWritten by Cursor Bugbot for commit 1f8f1e4. This will update automatically on new commits. Configure here.