Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Feb 11, 2026

Genericizes the error message when a user subcluster requests a system-only service to conceal system internals.


Note

Low Risk
Small behavior change limited to error messaging in service validation; core launch logic and authorization semantics remain the same.

Overview
User subclusters that request a systemOnly kernel service now fail with the same no registered kernel service '<name>' error used for unknown services, instead of a distinct "restricted to system subclusters" message.

Updates SubclusterManager service validation and adjusts the corresponding unit test expectation to match the new generic error.

Written by Cursor Bugbot for commit fcfa449. This will update automatically on new commits. Configure here.

@rekmarks rekmarks requested a review from a team as a code owner February 11, 2026 19:18
@rekmarks rekmarks requested a review from FUDCo February 11, 2026 19:18
@rekmarks rekmarks enabled auto-merge February 11, 2026 19:18
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mahvelous!

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.85%
⬇️ -0.01%
6284 / 8071
🔵 Statements 77.81%
⬇️ -0.01%
6385 / 8205
🔵 Functions 75.82%
🟰 ±0%
1581 / 2085
🔵 Branches 77.78%
⬇️ -0.01%
2318 / 2980
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/ocap-kernel/src/vats/SubclusterManager.ts 97.43%
⬇️ -0.04%
91.11%
⬇️ -0.19%
100%
🟰 ±0%
97.39%
⬇️ -0.04%
203, 269, 275-277
Generated in workflow #3716 for commit fcfa449 by the Vitest Coverage Report Action

@rekmarks rekmarks added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit e7a8633 Feb 11, 2026
29 checks passed
@rekmarks rekmarks deleted the rekm/restricted-service-error branch February 11, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants