Conversation
PR #857 added allowedWsHosts to RemoteCommsOptions and the transport layer but not to the RPC handler's superstruct validation. Daemon callers passing allowedWsHosts get a validation error because the params struct rejects the unknown field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
rekmarks
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowedWsHoststo theinitRemoteCommsRPC handler's superstruct params validationkernel.initRemoteComms(options)allowedWsHoststoRemoteCommsOptionsand the transport/connection-factory layer but missed the RPC handler, so daemon callers passingallowedWsHostsget a validation errorTest plan
yarn workspace @metamask/ocap-kernel test:dev:quiet— existing tests passocap daemon exec initRemoteComms '{"relays":["/ip4/1.2.3.4/tcp/9001/ws/p2p/..."],"allowedWsHosts":["1.2.3.4"]}'— no longer rejected🤖 Generated with Claude Code
Note
Low Risk
Low risk: adds a new optional RPC param and passes it through to existing remote comms initialization, with validation limited to a string array.
Overview
Fixes the
initRemoteCommsRPC handler to accept an optionalallowedWsHostsarray in its superstruct params validation.When provided, the handler now threads
allowedWsHostsintoRemoteCommsOptionspassed tokernel.initRemoteComms, preventing callers from being rejected due to unknown params.Written by Cursor Bugbot for commit 4085270. This will update automatically on new commits. Configure here.