fix(pr-skill): move changelog phase after PR creation#934
Merged
Conversation
Changelog entries need the PR number for links (e.g. `[#123]`), so they must be written after the PR is created, not before. Also adds stronger emphasis on consumer-perspective thinking and combining like changes, per the updating-changelogs.md instructions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sirtimid
added
the
no-changelog
When a PR has no consumer-facing changes, the skill now adds the `no-changelog` label instead of silently skipping. This prevents CI changelog validation failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f4f372f. Configure here.
Move the "return PR URL" instruction out of Phase 4 and into a final "Done" section after Phase 5, so an agent following the instructions sequentially won't interpret "Return" as a signal to end the workflow before updating changelogs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
@grypez did you have an idea for forcing the agent to do what we want by means of a bash invocation? |
Contributor
Seems to be more trouble than it's worth. Also, passing context from agent to subagent is not supported via this method without building more infrastructure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The changelog update phase needs the PR number to create proper links (e.g.
[#123]) in entries. Previously, changelogs were updated in Phase 4 before the PR was created in Phase 5, making it impossible to include the PR link.updating-changelogs.mdrules that were being missed: consumer-perspective thinking, combining like changes, splitting disparate changes, and linking the PR numberTesting
This is a docs-only change to a Claude Code skill definition. Verified the final file reads correctly with proper phase ordering and emphasis.
🤖 Generated with Claude Code
Note
Low Risk
Docs-only change to the PR-creation skill workflow; minimal risk beyond process/labeling instructions potentially being followed incorrectly.
Overview
Reorders the
prClaude skill workflow so the PR is created in Phase 4 before changelog updates, ensuring the PR number is available for changelog links.Adds explicit Phase 5 guidance to either apply a
no-changeloglabel for non-consumer-facing changes or update changelogs with emphasized rules (consumer-focused wording, combining/splitting entries, and linking the PR) before presenting results.Reviewed by Cursor Bugbot for commit d817845. Bugbot is set up for automated code reviews on this repo. Configure here.