Skip to content

chore: Update base-controller dependency#244

Merged
Gudahtt merged 2 commits intomainfrom
update-base-controller
Sep 4, 2025
Merged

chore: Update base-controller dependency#244
Gudahtt merged 2 commits intomainfrom
update-base-controller

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 4, 2025

Update from @metamask/base-controller v7 to v8. This breaking change had a limited direct impact on this package, only requiring the renaming of two imports (ControllerMessenger to Messeger, and RestrictedControllerMessenger to RestrictedMessenger).

Updating this dependency introduced an incompatibility with the older version of the NetworkController, so that had to be updated as well. Additionally the error-reporting-service was added as a peer dependency because it's now a peer dependency of
@metamask/network-controller, so it was required to satisfy peer dependency requirements. Additionally this package was required in order to build this package, because the types are a part of the public API (indirectly, via the NetworkController).

This update unblocks the adoption of new controller metadata properties, which itself is a blocker for #243

Update from `@metamask/base-controller` v7 to v8. This breaking change
had a limited direct impact on this package, only requiring the
renaming of two imports (`ControllerMessenger` to `Messeger`, and
`RestrictedControllerMessenger` to `RestrictedMessenger`).

Updating this dependency introduced an incompatibility with the older
version of the `NetworkController`, so that had to be updated as well.
Additionally the `error-reporting-service` was added as a peer
dependency because it's now a peer dependency of
`@metamask/network-controller`, so it was required to satisfy peer
dependency requirements. Additionally this package was required in
order to build this package, because the types are a part of the public
API (indirectly, via the `NetworkController`).

This update unblocks the adoption of new controller metadata
properties, which itself is a blocker for #243
@Gudahtt Gudahtt marked this pull request as ready for review September 4, 2025 20:47
@Gudahtt Gudahtt requested a review from a team as a code owner September 4, 2025 20:47
Copy link

@AugmentedMode AugmentedMode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@Gudahtt Gudahtt merged commit 90e4ae8 into main Sep 4, 2025
18 checks passed
@Gudahtt Gudahtt deleted the update-base-controller branch September 4, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants