Merged
Conversation
Update from `@metamask/base-controller` v7 to v8. This breaking change had a limited direct impact on this package, only requiring the renaming of two imports (`ControllerMessenger` to `Messeger`, and `RestrictedControllerMessenger` to `RestrictedMessenger`). Updating this dependency introduced an incompatibility with the older version of the `NetworkController`, so that had to be updated as well. Additionally the `error-reporting-service` was added as a peer dependency because it's now a peer dependency of `@metamask/network-controller`, so it was required to satisfy peer dependency requirements. Additionally this package was required in order to build this package, because the types are a part of the public API (indirectly, via the `NetworkController`). This update unblocks the adoption of new controller metadata properties, which itself is a blocker for #243
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
AugmentedMode
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update from
@metamask/base-controllerv7 to v8. This breaking change had a limited direct impact on this package, only requiring the renaming of two imports (ControllerMessengertoMesseger, andRestrictedControllerMessengertoRestrictedMessenger).Updating this dependency introduced an incompatibility with the older version of the
NetworkController, so that had to be updated as well. Additionally theerror-reporting-servicewas added as a peer dependency because it's now a peer dependency of@metamask/network-controller, so it was required to satisfy peer dependency requirements. Additionally this package was required in order to build this package, because the types are a part of the public API (indirectly, via theNetworkController).This update unblocks the adoption of new controller metadata properties, which itself is a blocker for #243