Skip to content

Standardize tsconfig files#458

Merged
mcmire merged 1 commit intomainfrom
standardize-tsconfigs
Nov 26, 2024
Merged

Standardize tsconfig files#458
mcmire merged 1 commit intomainfrom
standardize-tsconfigs

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Nov 8, 2024

This project has two kinds of TypeScript config files, which is consistent with the module template. However, whereas in the module template, the default config file (tsconfig.json) is the one used for development and tsconfig.build.json is used to build the project, in this repo it's reversed (tsconfig.test.json used for development).

This commit aligns the kinds of TypeScript configuration files with the module template. It also normalizes the existing options to fit the module template. There should be no differences to dist/.

@mcmire mcmire requested a review from a team November 8, 2024 17:30
@mcmire mcmire requested a review from a team November 8, 2024 17:31
@mcmire mcmire force-pushed the standardize-tsconfigs branch 3 times, most recently from c8fdbd2 to b48e7e5 Compare November 8, 2024 17:45
This project has two kinds of TypeScript config files, which is
consistent with the module template. However, whereas in the module
template, the default config file (`tsconfig.json`) is the one used for
development and `tsconfig.build.json` is used to build the project, in
this repo it's reversed (`tsconfig.test.json` used for development).

This commit aligns the kinds of TypeScript configuration files with the
module template. It also normalizes the existing options to fit the
module template. There should be no differences to `dist/`.
@mcmire mcmire force-pushed the standardize-tsconfigs branch from b48e7e5 to f25cf96 Compare November 8, 2024 17:48
@mcmire mcmire self-assigned this Nov 26, 2024
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit fc90a52 into main Nov 26, 2024
@mcmire mcmire deleted the standardize-tsconfigs branch November 26, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants