chore: bump deps, replace ErrorReportingService with messenger.captureException#572
Conversation
…eException - Bump network-controller ^25 → ^30, transaction-controller ^61 → ^63, remote-feature-flag-controller ^2 → ^4.1 - Replace ErrorReportingService:captureException action with messenger.captureException - Move controller peer deps to direct dependencies - Remove @metamask/error-reporting-service (deprecated)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
Ignoring alerts on:
|
|
@SocketSecurity ignore npm/@metamask/core-backend@6.1.1 |
|
@SocketSecurity ignore npm/@metamask/gas-fee-controller@26.1.0 |
|
@SocketSecurity ignore npm/@metamask/phishing-controller@16.3.0 |
|
@SocketSecurity ignore npm/@metamask/profile-sync-controller@28.0.0 |
|
@SocketSecurity ignore npm/@metamask/snaps-controllers@17.2.1 |
|
@SocketSecurity ignore npm/@metamask/snaps-rpc-methods@14.3.0 |
|
@SocketSecurity ignore npm/@metamask/snaps-sdk@10.4.0 |
|
@SocketSecurity ignore npm/@metamask/snaps-sdk@11.0.0 |
|
@SocketSecurity ignore npm/@metamask/snaps-utils@11.7.1 |
|
@SocketSecurity ignore npm/@metamask/snaps-utils@12.1.1 |
mcmire
left a comment
There was a problem hiding this comment.
I looked over the dependencies you're bumping and didn't notice any breaking changes, although I would definitely test this change in the clients to confirm. Other than that I have one suggestion to the changelog.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
|
@metamaskbot publish-preview |
What
ErrorReportingService:captureExceptionmessenger action withmessenger.captureException@metamask/error-reporting-servicedependency (deprecated in v3.0.1)@metamask/network-controller^25 → ^30@metamask/transaction-controller^61 → ^63@metamask/remote-feature-flag-controller^2 → ^4.1@metamask/polling-controller^15 → ^16@metamask/gas-fee-controller^22 → ^26 (dev)Why
@metamask/error-reporting-serviceis deprecated in favor ofMessenger.captureException. This removes the dependency and theErrorReportingService:captureExceptionallowed action from the messenger, so consumers must stop allowlisting it.Bumping
polling-controllerandgas-fee-controllerresolves peer dependency warnings againstnetwork-controller^30.Breaking changes
ErrorReportingService:captureExceptionis no longer an allowed action on the messenger@metamask/error-reporting-serviceis no longer a dependencyNote
Medium Risk
Introduces a breaking messenger API change by removing the
ErrorReportingService:captureExceptionallowed action, and upgrades several controller dependencies to new major versions which may affect integration behavior.Overview
Updates error reporting to use
messenger.captureExceptiondirectly, removing theErrorReportingService:captureExceptionmessenger action (and updating tests accordingly).Moves key MetaMask controller packages from
peerDependenciesto directdependenciesand bumps to newer major versions (notablynetwork-controller,transaction-controller,remote-feature-flag-controller,polling-controller, plusgas-fee-controllerin dev), with correspondinglavamoatallowlist additions and lockfile updates.Written by Cursor Bugbot for commit 03e734e. This will update automatically on new commits. Configure here.