Skip to content

feat(STX-501): add remote feature flag routing to getAPIRequestURL for sentinel migration#580

Merged
rarquevaux merged 1 commit intomainfrom
feat/STX-501-stx-controller-sentinel-migration-flags
Apr 16, 2026
Merged

feat(STX-501): add remote feature flag routing to getAPIRequestURL for sentinel migration#580
rarquevaux merged 1 commit intomainfrom
feat/STX-501-stx-controller-sentinel-migration-flags

Conversation

@rarquevaux
Copy link
Copy Markdown
Contributor

@rarquevaux rarquevaux commented Apr 15, 2026

Summary

  • Adds remote feature flag–controlled routing to getAPIRequestURL() via an optional useSentinel parameter
  • Gates each of the four sentinel endpoints (BATCH_STATUS, GET_FEES, SUBMIT_TRANSACTIONS, CANCEL) behind a dedicated LaunchDarkly flag
  • All flags default to false — no production traffic shifts on merge; each endpoint can be switched independently

Test plan

  • yarn test — all tests pass
  • yarn lint:fix — 0 errors

Note

Medium Risk
Touches Smart Transactions fee/status/submit/cancel API routing; while gated by remote flags defaulting off, misconfigured flags could shift traffic to new Sentinel endpoints and affect transaction flows.

Overview
Adds remote-feature-flag controlled routing to send Smart Transactions GET_FEES, SUBMIT_TRANSACTIONS, CANCEL, and BATCH_STATUS requests to Sentinel /v1/... endpoints on supported chains.

SmartTransactionsController now reads per-endpoint migration flags (e.g., stxMigrationGetFees) and passes a new useSentinel option into getAPIRequestURL, which falls back to the legacy API_BASE_URL when disabled or unsupported. Unit tests expand coverage for the new useSentinel routing and fallback behavior.

Reviewed by Cursor Bugbot for commit 43e8d91. Bugbot is set up for automated code reviews on this repo. Configure here.

@rarquevaux rarquevaux force-pushed the feat/STX-501-stx-controller-sentinel-migration-flags branch 4 times, most recently from ac311a1 to 66fb7cf Compare April 15, 2026 17:35
@rarquevaux rarquevaux marked this pull request as ready for review April 15, 2026 17:38
@rarquevaux rarquevaux requested a review from a team as a code owner April 15, 2026 17:38
@rarquevaux rarquevaux force-pushed the feat/STX-501-stx-controller-sentinel-migration-flags branch from 66fb7cf to 0c8d6bd Compare April 15, 2026 21:53
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0c8d6bd. Configure here.

Gate each sentinel API endpoint behind a dedicated remote feature flag.
@rarquevaux rarquevaux force-pushed the feat/STX-501-stx-controller-sentinel-migration-flags branch from 0c8d6bd to 43e8d91 Compare April 15, 2026 22:17
@MetaMask MetaMask deleted a comment from cursor bot Apr 15, 2026
@rarquevaux rarquevaux merged commit 5eec8f3 into main Apr 16, 2026
18 checks passed
@rarquevaux rarquevaux deleted the feat/STX-501-stx-controller-sentinel-migration-flags branch April 16, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants