Skip to content

Adds nonce to a tx, adds yarn build:link support, updates functions for API calls, refactoring#8

Merged
dan437 merged 19 commits intomainfrom
improvements
Oct 7, 2021
Merged

Adds nonce to a tx, adds yarn build:link support, updates functions for API calls, refactoring#8
dan437 merged 19 commits intomainfrom
improvements

Conversation

@dan437
Copy link
Collaborator

@dan437 dan437 commented Oct 6, 2021

Description

This PR:

  • Adds nonce to a tx during the getUnsignedTransactionsAndEstimates call
  • Adds yarn build:link support and documentation. This way we can easily make changes in the controller and see them e.g. in the MM extension
  • Updates functions for API calls (renaming, returned values, types, use our new transaction APIs server URL)
  • Adds 'Content-Type': 'application/json' for each API call
  • Turns off "require-atomic-updates" in ESLint
  • Updates and refactor unit tests, so they are all green now and meet the Jest threshold

@dan437 dan437 requested a review from a team as a code owner October 6, 2021 09:53
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dan437 dan437 merged commit 1a6c749 into main Oct 7, 2021
@rekmarks rekmarks deleted the improvements branch October 20, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants