Skip to content

feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler#591

Open
Battambang wants to merge 9 commits intomainfrom
feat/signpsbt-sendtransfer-confirmation-dialog
Open

feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler#591
Battambang wants to merge 9 commits intomainfrom
feat/signpsbt-sendtransfer-confirmation-dialog

Conversation

@Battambang
Copy link
Contributor

@Battambang Battambang commented Mar 13, 2026

Explanation

This PR contributes to supporting the Bitcoin dApp connectivity.
It's adding the a confirmation dialog to the user before a dApp calling for a sendTransfer() and before signing a PSBT from the keyring handler entrypoint.

It is part from the initial PR #564 feat: enable account address resolution to support dApps connectivity to split the work into 3 smaller PRs:
#589 refactor: move validation structs and add account field
#590 feat: add resolveAccountAddress method to KeyringHandler for dApp connectivity routing
#591 feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler

Confirmation dialog

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Adds new user-confirmation gates to signPsbt and sendTransfer flows and introduces resolveAccountAddress routing, changing how keyring requests are validated and executed. Moderate risk due to impacting transaction signing/sending UX and request routing/validation paths.

Overview
Adds explicit confirmation UX before executing keyring-initiated signPsbt and sendTransfer, including a new SignPsbtConfirmationView that displays parsed outputs, fees, and sign options (with best-effort fiat exchange rate lookup).

Extends keyring support with KeyringRpcMethod.ResolveAccountAddress (KeyringHandler.resolveAccountAddress) so MetaMask can route BTC dapp signing requests to the right account, and tightens request validation by requiring an account: { address } param across BTC wallet request structs.

Updates sendTransfer to only allow a single recipient, honor frozen UTXOs, and build the PSBT with fee rate/unspendables before confirmation; tests and locales are updated accordingly.

Written by Cursor Bugbot for commit 89127a1. This will update automatically on new commits. Configure here.

@Battambang Battambang requested a review from a team as a code owner March 13, 2026 23:50
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@Battambang
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.0-preview-89127a1"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant