feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler#591
Open
Battambang wants to merge 9 commits intomainfrom
Open
Conversation
…ddress } to all request types
…quest for integration tests
…nectivity routing
…ready guarantees the method is valid
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
8944681 to
89127a1
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
This PR contributes to supporting the Bitcoin dApp connectivity.
It's adding the a confirmation dialog to the user before a dApp calling for a sendTransfer() and before signing a PSBT from the keyring handler entrypoint.
It is part from the initial PR #564 feat: enable account address resolution to support dApps connectivity to split the work into 3 smaller PRs:
#589 refactor: move validation structs and add account field
#590 feat: add resolveAccountAddress method to KeyringHandler for dApp connectivity routing
#591 feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler
References
Checklist
Note
Medium Risk
Adds new user-confirmation gates to
signPsbtandsendTransferflows and introducesresolveAccountAddressrouting, changing how keyring requests are validated and executed. Moderate risk due to impacting transaction signing/sending UX and request routing/validation paths.Overview
Adds explicit confirmation UX before executing keyring-initiated
signPsbtandsendTransfer, including a newSignPsbtConfirmationViewthat displays parsed outputs, fees, and sign options (with best-effort fiat exchange rate lookup).Extends keyring support with
KeyringRpcMethod.ResolveAccountAddress(KeyringHandler.resolveAccountAddress) so MetaMask can route BTC dapp signing requests to the right account, and tightens request validation by requiring anaccount: { address }param across BTC wallet request structs.Updates
sendTransferto only allow a single recipient, honor frozen UTXOs, and build the PSBT with fee rate/unspendables before confirmation; tests and locales are updated accordingly.Written by Cursor Bugbot for commit 89127a1. This will update automatically on new commits. Configure here.