Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
montelaidev
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the snap-side keyring stack to match what metamask-extension and metamask-mobile are now using on main. The ^21 → ^23 jump in
@metamask/keyring-apikeeps the snap aligned with consumers so the JSON-RPC contract between them doesn't drift across major versions.This is a dep-bump-only PR. A separate release PR will follow to publish 2.1.0 of both packages; the currently published 2.0.0 predates #169 and still bundles
keyring-api@^8, which is incompatible with the extension's stricter v23 response validation (will be needed for MetaMask/metamask-extension#42334).Changes
packages/snap
@metamask/keyring-api: ^21.0.0 → ^23.1.0@metamask/keyring-snap-sdk: ^7.0.0 → ^9.0.1@metamask/snaps-sdk: 7.1.0 → ^11.1.0@metamask/utils: ^8.1.0 → ^11.11.0snap.manifest.jsonplatformVersion: 7.1.0 → 11.1.0 + new shasumpackages/site
@metamask/keyring-api: ^21.0.0 → ^23.1.0@metamask/keyring-snap-client: ^8.0.0 → ^9.0.2@metamask/providers: ^13.0.0 → ^19.0.0yarn.lockwas regenerated. Notably,@metamask/superstructmoves from 3.1.0 → 3.2.1 (within everyone's existing ^3.1.0 range). 3.2.0+ is required becausekeyring-api@23.1.0's ESM build importsexactOptionalfrom@metamask/superstruct, which is only re-exported starting at 3.2.0. clients' e2e environments.Note
Medium Risk
Primarily dependency upgrades, but they include multiple major-version bumps (
@metamask/snaps-sdk,@metamask/providers,@metamask/keyring-*) and aplatformVersionchange that could affect runtime compatibility across snap/extension consumers.Overview
Updates both the snap and companion site to newer MetaMask keyring/snap libraries, including major bumps to
@metamask/keyring-api,@metamask/snaps-sdk,@metamask/keyring-snap-sdk,@metamask/keyring-snap-client, and@metamask/providers.Aligns the snap manifest with the new snaps SDK by updating
snap.manifest.jsonplatformVersion(and sourceshasum), regeneratesyarn.lockaccordingly, and adds a small eslint suppression/comment inpackages/snap/src/index.tsforMethodNotSupportedErrortyping changes.Reviewed by Cursor Bugbot for commit e620b7f. Bugbot is set up for automated code reviews on this repo. Configure here.