-
Notifications
You must be signed in to change notification settings - Fork 639
perf!: Use mnemonic seed for entropy RPC methods #3220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3220 +/- ##
==========================================
- Coverage 94.94% 94.93% -0.01%
==========================================
Files 507 508 +1
Lines 11195 11219 +24
Branches 1723 1730 +7
==========================================
+ Hits 10629 10651 +22
- Misses 566 568 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
fb/use-mnemonic-seed-for-state-persistence
to
main
March 13, 2025 09:18
055b888 to
874c2f8
Compare
Mrtenz
requested changes
Mar 13, 2025
Mrtenz
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the implementations of the entropy RPC methods to use
getMnemonicSeedif the curve being used is eithersecp256k1ored25519. This let's us skip the most computationally heavy part of the key derivation by re-using the already derived BIP-39 seed.Closes #3219
Breaking changes
getMnemonicSeedhook is now required to support all entropy RPC methods.getMnemoniccan not be removed as that is still also in use.