Remove @metamask/snaps-simulator
#3311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.
|
Mrtenz
commented
Apr 9, 2025
| "@noble/hashes": "^1.7.1", | ||
| "@swc/core": "1.3.78", | ||
| "@swc/jest": "^0.2.26", | ||
| "@testing-library/dom": "^10.4.0", |
Member
Author
There was a problem hiding this comment.
@vitest/browsers apparently has an implicit dependency on @testing-library/dom. This was previously brought in by @metamask/snaps-simulator, but now it needs to be explicitly added to packages using it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3311 +/- ##
==========================================
+ Coverage 94.73% 97.81% +3.07%
==========================================
Files 518 365 -153
Lines 11947 9970 -1977
Branches 1836 1627 -209
==========================================
- Hits 11318 9752 -1566
+ Misses 629 218 -411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be replaced with
@metamask/snaps-sandboxin #3306.