Skip to content

ci: Fix update workflow to use latest yarn.lock changes#3379

Merged
Mrtenz merged 2 commits intomainfrom
mrtenz/fix-update-workflow
May 6, 2025
Merged

ci: Fix update workflow to use latest yarn.lock changes#3379
Mrtenz merged 2 commits intomainfrom
mrtenz/fix-update-workflow

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented May 6, 2025

Currently we cache the node_modules folder and restore it from cache in the steps after. This means that any changes to the yarn.lock file made in the deduplication step are not used for generating LavaMoat policies or building the examples, sometimes resulting in errors.

To fix it, I've added a check which checks if the yarn.lock was updated. The other steps will use a high risk environment which skips loading the node_modules cache if that's the case.

@Mrtenz Mrtenz requested a review from a team as a code owner May 6, 2025 10:59
@Mrtenz Mrtenz enabled auto-merge May 6, 2025 11:08
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (75acad8) to head (7ac1e25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3379   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         397      397           
  Lines       10929    10929           
  Branches     1720     1720           
=======================================
  Hits        10718    10718           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 93a31e2 May 6, 2025
115 checks passed
@Mrtenz Mrtenz deleted the mrtenz/fix-update-workflow branch May 6, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants