refactor: Simplify RPC handling in SnapController #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/simplify-controller-rpc
branch
from
f5a49ff to
9f713d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
+ Coverage 98.13% 98.14% +0.01%
==========================================
Files 400 399 -1
Lines 11027 10990 -37
Branches 1738 1729 -9
==========================================
- Hits 10821 10786 -35
+ Misses 206 204 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
force-pushed
the
fb/simplify-controller-rpc
branch
from
9f713d1 to
dff1689
Compare
FrederikBolding
force-pushed
the
fb/simplify-controller-rpc
branch
from
dff1689 to
6df8fb0
Compare
Mrtenz
requested changes
May 22, 2025
| const result = await withTimeout(handleRpcRequestPromise, timer); | ||
|
|
||
| if (result === hasTimedOut) { | ||
| throw new Error(`${snapId} failed to respond to the request in time.`); |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| throw new Error(`${snapId} failed to respond to the request in time.`); | |
| throw new Error(`Snap "${snapId}" failed to respond to the request in time.`); |
Member
Author
There was a problem hiding this comment.
Currently mirrors the error message from the execution service: https://github.com/MetaMask/snaps/blob/fb/simplify-controller-rpc/packages/snaps-controllers/src/services/AbstractExecutionService.ts#L378
IMO keep as-is.
Member
There was a problem hiding this comment.
Preferably we update those too, but fine with me to do in a separate PR as well.
Member
Author
There was a problem hiding this comment.
IMO out of scope then 😄
Mrtenz
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop storing an RPC handler in the runtime for Snaps, instead just move the handler code directly to
handleRequest. Also removes theRequestQueuepreviously used during the Snap starting up, instead we let as many requests as needed wait forstartPromise. This simplifies RPC request routing significantly.Recommend reviewing this with whitespace changes not displayed 😄