Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jan 21, 2026

This is a follow up to #3805, allowing --manifest to be used for the build command as well (as long as --preinstalled is also specified). This allows creating preinstalled bundles with a custom manifest, for testing purposes.


Note

Adds --manifest support to build with validation and centralizes manifest path handling.

  • Build command: Adds --manifest option, enforces --preinstalled when provided via yargs.check, and passes config through getConfigWithManifest.
  • Utility: Introduces getConfigWithManifest to resolve and apply a custom manifest path; reused by watch.
  • Tests: Add tests for custom manifest path, validation error when --manifest is used without --preinstalled, and unit tests for the new utility.

Written by Cursor Bugbot for commit a325527. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review January 21, 2026 13:34
@Mrtenz Mrtenz requested a review from a team as a code owner January 21, 2026 13:34
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.35%. Comparing base (9f90234) to head (a325527).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3811   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         430      430           
  Lines       12333    12340    +7     
  Branches     1919     1919           
=======================================
+ Hits        12130    12137    +7     
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@Mrtenz Mrtenz enabled auto-merge January 22, 2026 09:30
@Mrtenz Mrtenz added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 500ea37 Jan 22, 2026
128 checks passed
@Mrtenz Mrtenz deleted the mrtenz/build-custom-manifest branch January 22, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants