-
Notifications
You must be signed in to change notification settings - Fork 642
feat: Support --manifest option in build command
#3811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3811 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 430 430
Lines 12333 12340 +7
Branches 1919 1919
=======================================
+ Hits 12130 12137 +7
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
This is a follow up to #3805, allowing
--manifestto be used for thebuildcommand as well (as long as--preinstalledis also specified). This allows creating preinstalled bundles with a custom manifest, for testing purposes.Note
Adds
--manifestsupport tobuildwith validation and centralizes manifest path handling.--manifestoption, enforces--preinstalledwhen provided viayargs.check, and passes config throughgetConfigWithManifest.getConfigWithManifestto resolve and apply a custom manifest path; reused bywatch.--manifestis used without--preinstalled, and unit tests for the new utility.Written by Cursor Bugbot for commit a325527. This will update automatically on new commits. Configure here.