chore: Remove phishing-controller dependency

[FrederikBolding]

The recent phishing-controller version includes transaction-controller as a dependency. To simplify that Snaps dependency tree, we can use a copied type.

---

Note

Low Risk
Primarily dependency/type cleanup; runtime behavior is unchanged aside from relying on a looser local type for the phishing action response.

Overview
Removes the @metamask/phishing-controller dependency from Snaps packages (snaps-controllers, snaps-jest, snaps-simulation) and updates the lockfile accordingly to simplify the dependency tree.

Replaces imports of phishing-controller types with a locally defined PhishingController:testOrigin action type in SnapInterfaceController, and updates tests/mocks to return the expected phishing result type as the string 'all' instead of PhishingDetectorResultType.All.

^{Written by Cursor Bugbot for commit 2107037. This will update automatically on new commits. Configure here.}

[Mrtenz]

Is as const necessary? 🤔

[FrederikBolding]

Probably not actually, will fix.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (b3b2c42) to head (2107037).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3852      +/-   ##
==========================================
- Coverage   98.59%   98.59%   -0.01%     
==========================================
  Files         429      429              
  Lines       12417    12416       -1     
  Branches     1928     1928              
==========================================
- Hits        12242    12241       -1     
  Misses        175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.